Changeset 143402 in webkit

Timestamp:

Feb 19, 2013 4:15:23 PM (11 years ago)

Author:

tonyg@chromium.org

Message:

Fix checkThatTokensAreSafeToSendToAnotherThread() now that the preload scanner is enabled
​https://bugs.webkit.org/show_bug.cgi?id=110258

Reviewed by Adam Barth.

We were hitting this ASSERT on numerous tests with the background parser enabled. This copy fixes the assertion.

No new tests becuase covered by existing tests.

• html/parser/HTMLResourcePreloader.h:

(WebCore::PreloadRequest::setCharset):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/parser/HTMLResourcePreloader.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-19  Tony Gentilcore  <tonyg@chromium.org>
+
+        Fix checkThatTokensAreSafeToSendToAnotherThread() now that the preload scanner is enabled
+        https://bugs.webkit.org/show_bug.cgi?id=110258
+
+        Reviewed by Adam Barth.
+
+        We were hitting this ASSERT on numerous tests with the background parser enabled. This copy fixes the assertion.
+
+        No new tests becuase covered by existing tests.
+
+        * html/parser/HTMLResourcePreloader.h:
+        (WebCore::PreloadRequest::setCharset):
+
 2013-02-19  Tony Gentilcore  <tonyg@chromium.org>
 

trunk/Source/WebCore/html/parser/HTMLResourcePreloader.h

@@ -44 +44 @@
 
     const String& charset() const { return m_charset; }
-    void setCharset(const String& charset) { m_charset = charset; }
+    void setCharset(const String& charset) { m_charset = charset.isolatedCopy(); }
     void setCrossOriginModeAllowsCookies(bool allowsCookies) { m_crossOriginModeAllowsCookies = allowsCookies; }
     CachedResource::Type resourceType() const { return m_resourceType; }