Changeset 143432 in webkit

Timestamp:

Feb 19, 2013 10:54:23 PM (11 years ago)

Author:

aandrey@chromium.org

Message:

Few methods in WebGLRenderingContext.idl have incorrect signatures
​https://bugs.webkit.org/show_bug.cgi?id=110305

Reviewed by Kentaro Hara.

• html/canvas/WebGLRenderingContext.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/canvas/WebGLRenderingContext.idl (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-19  Andrey Adaikin  <aandrey@chromium.org>
+
+        Few methods in WebGLRenderingContext.idl have incorrect signatures
+        https://bugs.webkit.org/show_bug.cgi?id=110305
+
+        Reviewed by Kentaro Hara.
+
+        * html/canvas/WebGLRenderingContext.idl:
+
 2013-02-19  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/html/canvas/WebGLRenderingContext.idl

@@ -515 +515 @@
     [StrictTypeChecking] void         depthFunc(in GLenum func);
     [StrictTypeChecking] void         depthMask(in GLboolean flag);
-    // FIXME: this differs from the current WebGL spec (depthRangef)
     [StrictTypeChecking] void         depthRange(in GLclampf zNear, in GLclampf zFar);
     [StrictTypeChecking] void         detachShader(in WebGLProgram program, in WebGLShader shader) raises(DOMException);
@@ -539 +538 @@
     [StrictTypeChecking] GLint        getAttribLocation(in WebGLProgram program, in DOMString name);
 
-    // any getBufferParameter(in GLenum target, in GLenum pname) raises(DOMException);
-    [StrictTypeChecking, Custom] void getBufferParameter();
+    [StrictTypeChecking, Custom] any getBufferParameter(in GLenum target, in GLenum pname);
 
     [StrictTypeChecking] WebGLContextAttributes getContextAttributes();
@@ -549 +547 @@
     [StrictTypeChecking, Custom] any getExtension(in DOMString name);
 
-    // any getFramebufferAttachmentParameter(in GLenum target, in GLenum attachment, in GLenum pname) raises(DOMException);
-    [StrictTypeChecking, Custom] void getFramebufferAttachmentParameter();
-    // any getParameter(in GLenum pname) raises(DOMException);
-    [StrictTypeChecking, Custom] void getParameter();
-    // any getProgramParameter(in WebGLProgram program, in GLenum pname) raises(DOMException);
-    [StrictTypeChecking, Custom] void getProgramParameter();
+    [StrictTypeChecking, Custom] any getFramebufferAttachmentParameter(in GLenum target, in GLenum attachment, in GLenum pname) raises(DOMException);
+    [StrictTypeChecking, Custom] any getParameter(in GLenum pname) raises(DOMException);
+    [StrictTypeChecking, Custom] any getProgramParameter(in WebGLProgram program, in GLenum pname) raises(DOMException);
     [StrictTypeChecking, TreatReturnedNullStringAs=Null] DOMString getProgramInfoLog(in WebGLProgram program) raises(DOMException);
-    // any getRenderbufferParameter(in GLenum target, in GLenum pname) raises(DOMException);
-    [StrictTypeChecking, Custom] void getRenderbufferParameter();
-    // any getShaderParameter(in WebGLShader shader, in GLenum pname) raises(DOMException);
-    [StrictTypeChecking, Custom] void getShaderParameter() raises(DOMException);
+    [StrictTypeChecking, Custom] any getRenderbufferParameter(in GLenum target, in GLenum pname) raises(DOMException);
+    [StrictTypeChecking, Custom] any getShaderParameter(in WebGLShader shader, in GLenum pname) raises(DOMException);
 
     [StrictTypeChecking, TreatReturnedNullStringAs=Null] DOMString    getShaderInfoLog(in WebGLShader shader) raises(DOMException);
@@ -569 +562 @@
     [StrictTypeChecking, Custom] sequence<DOMString> getSupportedExtensions();
 
-    // any getTexParameter(in GLenum target, in GLenum pname) raises(DOMException);
-    [StrictTypeChecking, Custom] void getTexParameter();
-
-    // any getUniform(in WebGLProgram program, in WebGLUniformLocation location) raises(DOMException);
-    [StrictTypeChecking, Custom] void getUniform();
+    [StrictTypeChecking, Custom] any getTexParameter(in GLenum target, in GLenum pname) raises(DOMException);
+
+    [StrictTypeChecking, Custom] any getUniform(in WebGLProgram program, in WebGLUniformLocation location) raises(DOMException);
 
     [StrictTypeChecking] WebGLUniformLocation getUniformLocation(in WebGLProgram program, in DOMString name) raises(DOMException);
 
-    // any getVertexAttrib(in GLuint index, in GLenum pname) raises(DOMException);
-    [StrictTypeChecking, Custom] void getVertexAttrib();
+    [StrictTypeChecking, Custom] any getVertexAttrib(in GLuint index, in GLenum pname) raises(DOMException);
 
     [StrictTypeChecking] GLsizeiptr getVertexAttribOffset(in GLuint index, in GLenum pname);