Changeset 143502 in webkit


Ignore:
Timestamp:
Feb 20, 2013 1:53:27 PM (11 years ago)
Author:
krit@webkit.org
Message:

[Chromium] Add runtime flag for CanvasPath
​https://bugs.webkit.org/show_bug.cgi?id=109997

Reviewed by Adam Barth.

Source/WebCore:

Add runtime flag for Chromium.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setCanvasPathEnabled):
(WebCore::RuntimeEnabledFeatures::canvasPathEnabled):

  • html/canvas/DOMPath.idl:
  • page/DOMWindow.idl:

Source/WebKit/chromium:

Add runtime flag for Chromium.

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableCanvasPath):
(WebKit):
(WebKit::WebRuntimeFeatures::isCanvasPathEnabled):

Tools:

Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
the constructor for Path on DOMWindow would never be activatable, since the script
is running after creating the DOMWindow object.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

Location:
trunk
Files:
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r143500 r143502  
    43554355webkit.org/b/108508 fast/canvas/canvas-path-object.html [ Failure ]
    43564356webkit.org/b/108508 platform/chromium/virtual/gpu/fast/canvas/canvas-path-object.html [ Failure ]
     4357webkit.org/b/108508 inspector/profiler/canvas2d/canvas2d-api-changes.html [ Failure ]
    43574358
    43584359# This is won't fix, as the debug and release versions differ.

  • trunk/Source/WebCore/ChangeLog

    r143499 r143502  
     12013-02-15  Dirk Schulze  <krit@webkit.org>
     2
     3        [Chromium] Add runtime flag for CanvasPath
     4        https://bugs.webkit.org/show_bug.cgi?id=109997
     5
     6        Reviewed by Adam Barth.
     7
     8        Add runtime flag for Chromium.
     9
     10        * bindings/generic/RuntimeEnabledFeatures.cpp:
     11        (WebCore):
     12        * bindings/generic/RuntimeEnabledFeatures.h:
     13        (RuntimeEnabledFeatures):
     14        (WebCore::RuntimeEnabledFeatures::setCanvasPathEnabled):
     15        (WebCore::RuntimeEnabledFeatures::canvasPathEnabled):
     16        * html/canvas/DOMPath.idl:
     17        * page/DOMWindow.idl:
     18
    1192013-02-20  Laszlo Gombos  <l.gombos@samsung.com>
    220

  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp

    r142549 r143502  
    5555bool RuntimeEnabledFeatures::isDeviceOrientationEnabled = true;
    5656bool RuntimeEnabledFeatures::isSpeechInputEnabled = true;
     57bool RuntimeEnabledFeatures::isCanvasPathEnabled = false;
    5758bool RuntimeEnabledFeatures::isCSSExclusionsEnabled = false;
    5859bool RuntimeEnabledFeatures::isCSSRegionsEnabled = false;

  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h

    r142549 r143502  
    6464    static bool indexedDBEnabled() { return isIndexedDBEnabled; }
    6565
     66#if ENABLE(CANVAS_PATH)
     67    static void setCanvasPathEnabled(bool isEnabled) { isCanvasPathEnabled = isEnabled; }
     68    static bool canvasPathEnabled() { return isCanvasPathEnabled; }
     69#else
     70    static void setCanvasPathEnabled(bool) { }
     71    static bool canvasPathEnabled() { return false; }
     72#endif
     73
    6674#if ENABLE(CSS_EXCLUSIONS)
    6775    static void setCSSExclusionsEnabled(bool isEnabled) { isCSSExclusionsEnabled = isEnabled; }
    … …  
    286294    static bool isDeviceOrientationEnabled;
    287295    static bool isSpeechInputEnabled;
     296    static bool isCanvasPathEnabled;
    288297    static bool isCSSExclusionsEnabled;
    289298    static bool isCSSRegionsEnabled;

  • trunk/Source/WebCore/html/canvas/DOMPath.idl

    r141624 r143502  
    2828
    2929interface [
     30    V8EnabledAtRuntime=canvasPath,
    3031    Constructor,
    3132    Constructor(in DOMPath path),

  • trunk/Source/WebCore/page/DOMWindow.idl

    r143386 r143502  
    398398    attribute EntityConstructor Entity;
    399399    attribute EntityReferenceConstructor EntityReference;
    400     [Conditional=CANVAS_PATH] attribute DOMPathConstructor Path;
     400    [Conditional=CANVAS_PATH, V8EnabledAtRuntime=canvasPath] attribute DOMPathConstructor Path;
    401401    attribute ProcessingInstructionConstructor ProcessingInstruction;
    402402    [Conditional=SHADOW_DOM, V8EnabledAtRuntime=shadowDOM] attribute ShadowRootConstructor WebKitShadowRoot;

  • trunk/Source/WebKit/chromium/ChangeLog

    r143496 r143502  
     12013-02-15  Dirk Schulze  <krit@webkit.org>
     2
     3        [Chromium] Add runtime flag for CanvasPath
     4        https://bugs.webkit.org/show_bug.cgi?id=109997
     5
     6        Reviewed by Adam Barth.
     7
     8        Add runtime flag for Chromium.
     9
     10        * public/WebRuntimeFeatures.h:
     11        (WebRuntimeFeatures):
     12        * src/WebRuntimeFeatures.cpp:
     13        (WebKit::WebRuntimeFeatures::enableCanvasPath):
     14        (WebKit):
     15        (WebKit::WebRuntimeFeatures::isCanvasPathEnabled):
     16
    1172013-02-20  Mark Pilgrim  <pilgrim@chromium.org>
    218

  • trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h

    r142549 r143502  
    150150    WEBKIT_EXPORT static bool isDialogElementEnabled();
    151151
     152    WEBKIT_EXPORT static void enableCanvasPath(bool);
     153    WEBKIT_EXPORT static bool isCanvasPathEnabled();
     154   
    152155    WEBKIT_EXPORT static void enableCSSExclusions(bool);
    153156    WEBKIT_EXPORT static bool isCSSExclusionsEnabled();

  • trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp

    r142549 r143502  
    662662}
    663663
     664void WebRuntimeFeatures::enableCanvasPath(bool enable)
     665{
     666    RuntimeEnabledFeatures::setCanvasPathEnabled(enable);
     667}
     668
     669bool WebRuntimeFeatures::isCanvasPathEnabled()
     670{
     671    return RuntimeEnabledFeatures::canvasPathEnabled();
     672}
     673
    664674void WebRuntimeFeatures::enableCSSExclusions(bool enable)
    665675{

  • trunk/Tools/ChangeLog

    r143480 r143502  
     12013-02-15  Dirk Schulze  <krit@webkit.org>
     2
     3        [Chromium] Add runtime flag for CanvasPath
     4        https://bugs.webkit.org/show_bug.cgi?id=109997
     5
     6        Reviewed by Adam Barth.
     7
     8        Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
     9        the constructor for Path on DOMWindow would never be activatable, since the script
     10        is running after creating the DOMWindow object.
     11
     12        * DumpRenderTree/chromium/TestShell.cpp:
     13        (TestShell::TestShell):
     14
    1152013-02-20  Jochen Eisinger  <jochen@chromium.org>
    216

  • trunk/Tools/DumpRenderTree/chromium/TestShell.cpp

    r142929 r143502  
    151151    WebRuntimeFeatures::enableExperimentalContentSecurityPolicyFeatures(true);
    152152    WebRuntimeFeatures::enableSeamlessIFrames(true);
     153    WebRuntimeFeatures::enableCanvasPath(true);
    153154
    154155    // 30 second is the same as the value in Mac DRT.
Note: See TracChangeset for help on using the changeset viewer.