Changeset 143512 in webkit

Timestamp:

Feb 20, 2013 3:00:43 PM (11 years ago)

Author:

dgrogan@chromium.org

Message:

IndexedDB: Limit LevelDB's max open files
​https://bugs.webkit.org/show_bug.cgi?id=109993

Reviewed by Tony Chang.

LevelDB keeps up to 1000 (by default) data files open at a time to
avoid having to open() them. This has caused chromium to hit the
process-wide open file limit. This patch changes max_open_files to 20,
as that's the minimum permitted by LevelDB and we have no reason to
think that performance will suffer because of the extra open calls.

No new tests - a chromium browser test that tracks the open LevelDB
files is plausible but is blocked on ​http://crbug.com/177249/.

• platform/leveldb/LevelDBDatabase.cpp:

(WebCore::openDB):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/leveldb/LevelDBDatabase.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-20  David Grogan  <dgrogan@chromium.org>
+
+        IndexedDB: Limit LevelDB's max open files
+        https://bugs.webkit.org/show_bug.cgi?id=109993
+
+        Reviewed by Tony Chang.
+
+        LevelDB keeps up to 1000 (by default) data files open at a time to
+        avoid having to open() them. This has caused chromium to hit the
+        process-wide open file limit. This patch changes max_open_files to 20,
+        as that's the minimum permitted by LevelDB and we have no reason to
+        think that performance will suffer because of the extra open calls.
+
+        No new tests - a chromium browser test that tracks the open LevelDB
+        files is plausible but is blocked on http://crbug.com/177249/.
+
+        * platform/leveldb/LevelDBDatabase.cpp:
+        (WebCore::openDB):
+
 2013-02-20  David Hyatt  <hyatt@apple.com>
 

trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp

@@ -134 +134 @@
     options.create_if_missing = true;
     options.paranoid_checks = true;
+    // 20 max_open_files is the minimum LevelDB allows.
+    options.max_open_files = 20;
     options.env = env;