Changeset 143526 in webkit

Timestamp:

Feb 20, 2013 4:00:33 PM (11 years ago)

Author:

adamk@chromium.org

Message:

[v8] Fix an erroneous WrapperGrouper call in preparation for refactoring
​https://bugs.webkit.org/show_bug.cgi?id=110396

Reviewed by Kentaro Hara.

This is in preparation for a refactor to expose a simplified
WrapperGrouper interface to V8 wrapper classes enabling them to
specify multiple roots per wrapper object.

• bindings/v8/V8GCController.cpp: Since MutationObservers are not Nodes, the correct call here is addObjectToGroup, as it is for all other non-Node wrappers.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8GCController.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-20  Adam Klein  <adamk@chromium.org>
+
+        [v8] Fix an erroneous WrapperGrouper call in preparation for refactoring
+        https://bugs.webkit.org/show_bug.cgi?id=110396
+
+        Reviewed by Kentaro Hara.
+
+        This is in preparation for a refactor to expose a simplified
+        WrapperGrouper interface to V8 wrapper classes enabling them to
+        specify multiple roots per wrapper object. 
+
+        * bindings/v8/V8GCController.cpp: Since MutationObservers are not Nodes, the correct call here is addObjectToGroup, as it is for all other non-Node wrappers.
+
 2013-02-20  Levi Weintraub  <leviw@chromium.org>
 

trunk/Source/WebCore/bindings/v8/V8GCController.cpp

@@ -312 +312 @@
             HashSet<Node*> observedNodes = observer->getObservedNodes();
             for (HashSet<Node*>::iterator it = observedNodes.begin(); it != observedNodes.end(); ++it)
-                m_grouper.addNodeToGroup(V8GCController::opaqueRootForGC(*it, m_isolate), wrapper);
+                m_grouper.addObjectToGroup(V8GCController::opaqueRootForGC(*it, m_isolate), wrapper);
         } else {
             ActiveDOMObject* activeDOMObject = type->toActiveDOMObject(wrapper);