Changeset 143670 in webkit

Timestamp:

Feb 21, 2013 5:13:25 PM (11 years ago)

Author:

abarth@webkit.org

Message:

Threaded HTML Parser fails fast/dom/Document/readystate.html
​https://bugs.webkit.org/show_bug.cgi?id=110529

Reviewed by Eric Seidel.

Source/WebCore:

We need to create the tokenizer even when we finish a script-created
parser. Most of the time, the tokenizer has already been created at
this point because it is created by calls to document.write.

Test: fast/parser/body-should-exist-after-open-close.html

• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::finish):

LayoutTests:

This test is a reduction of the original issue.

• fast/parser/body-should-exist-after-open-close-expected.txt: Added.
• fast/parser/body-should-exist-after-open-close.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/parser/body-should-exist-after-open-close-expected.txt (added)
• LayoutTests/fast/parser/body-should-exist-after-open-close.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/parser/HTMLDocumentParser.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-02-21  Adam Barth  <abarth@webkit.org>
+
+        Threaded HTML Parser fails fast/dom/Document/readystate.html
+        https://bugs.webkit.org/show_bug.cgi?id=110529
+
+        Reviewed by Eric Seidel.
+
+        This test is a reduction of the original issue.
+
+        * fast/parser/body-should-exist-after-open-close-expected.txt: Added.
+        * fast/parser/body-should-exist-after-open-close.html: Added.
+
 2013-02-21  Rouslan Solomakhin  <rouslan@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-21  Adam Barth  <abarth@webkit.org>
+
+        Threaded HTML Parser fails fast/dom/Document/readystate.html
+        https://bugs.webkit.org/show_bug.cgi?id=110529
+
+        Reviewed by Eric Seidel.
+
+        We need to create the tokenizer even when we finish a script-created
+        parser. Most of the time, the tokenizer has already been created at
+        this point because it is created by calls to document.write.
+
+        Test: fast/parser/body-should-exist-after-open-close.html
+
+        * html/parser/HTMLDocumentParser.cpp:
+        (WebCore::HTMLDocumentParser::finish):
+
 2013-02-21  Emil A Eklund  <eae@chromium.org>
 

trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp

@@ -698 +698 @@
     }
 
-    if (shouldUseThreading() && !wasCreatedByScript()) {
-        ASSERT(!m_tokenizer && !m_token);
+    if (!m_tokenizer) {
+        ASSERT(!m_token);
         // We're finishing before receiving any data. Rather than booting up
         // the background parser just to spin it down, we finish parsing