Changeset 143931 in webkit


Ignore:
Timestamp:
Feb 25, 2013 8:56:14 AM (11 years ago)
Author:
sergio@webkit.org
Message:

[soup] "Too many redirects" error loading chat in plus.google.com
​https://bugs.webkit.org/show_bug.cgi?id=64575

Reviewed by Martin Robinson.

Source/WebCore:

Set the firstPartyForCookies for the new request on redirects to
the URL used for redirection.

Test: http/tests/cookies/set-cookie-on-redirect.html

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::doRedirect):

LayoutTests:

This new test checks firstPartyForCookies is properly set to the
new URL on redirects.

  • http/tests/cookies/resources/set-cookie-on-redirect.php: Added.
  • http/tests/cookies/set-cookie-on-redirect-expected.txt: Added.
  • http/tests/cookies/set-cookie-on-redirect.html: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r143925 r143931  
     12013-02-25  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        [soup] "Too many redirects" error loading chat in plus.google.com
     4        https://bugs.webkit.org/show_bug.cgi?id=64575
     5
     6        Reviewed by Martin Robinson.
     7
     8        This new test checks firstPartyForCookies is properly set to the
     9        new URL on redirects.
     10
     11        * http/tests/cookies/resources/set-cookie-on-redirect.php: Added.
     12        * http/tests/cookies/set-cookie-on-redirect-expected.txt: Added.
     13        * http/tests/cookies/set-cookie-on-redirect.html: Added.
     14
    1152013-02-25  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
    216

  • trunk/Source/WebCore/ChangeLog

    r143926 r143931  
     12013-02-25  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        [soup] "Too many redirects" error loading chat in plus.google.com
     4        https://bugs.webkit.org/show_bug.cgi?id=64575
     5
     6        Reviewed by Martin Robinson.
     7
     8        Set the firstPartyForCookies for the new request on redirects to
     9        the URL used for redirection.
     10
     11        Test: http/tests/cookies/set-cookie-on-redirect.html
     12
     13        * platform/network/soup/ResourceHandleSoup.cpp:
     14        (WebCore::doRedirect):
     15
    1162013-02-25  Andreas Kling  <akling@apple.com>
    217

  • trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp

    r143487 r143931  
    460460    bool crossOrigin = !protocolHostAndPortAreEqual(handle->firstRequest().url(), newURL);
    461461    newRequest.setURL(newURL);
     462    newRequest.setFirstPartyForCookies(newURL);
    462463
    463464    if (newRequest.httpMethod() != "GET") {
Note: See TracChangeset for help on using the changeset viewer.