Changeset 143990 in webkit

Timestamp:

Feb 25, 2013, 5:22:33 PM (13 years ago)

Author:

Simon Fraser

Message:

Lots of unnecessary DidLayout notifications when scrolling zoomed page with iframes
​https://bugs.webkit.org/show_bug.cgi?id=110824

Reviewed by Tim Horton.

RenderWidget::setWidgetGeometry() compares the old and new frame rects to decide
if the geometry changed. However, it use implicit IntRect->LayoutRect promotion in
the comparison, and then roundedIntRect() in setting. Thus the code would think
that the geometry changed, even when the final assigned frame did not.

Fix by computing the new frame using roundedIntRect(), and using that to determine
whether the geometry changed.

No way to test DidLayout notifications in DRT/WTR.

• rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderWidget.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-25  Simon Fraser  <simon.fraser@apple.com>
+
+        Lots of unnecessary DidLayout notifications when scrolling zoomed page with iframes
+        https://bugs.webkit.org/show_bug.cgi?id=110824
+
+        Reviewed by Tim Horton.
+        
+        RenderWidget::setWidgetGeometry() compares the old and new frame rects to decide
+        if the geometry changed. However, it use implicit IntRect->LayoutRect promotion in
+        the comparison, and then roundedIntRect() in setting. Thus the code would think
+        that the geometry changed, even when the final assigned frame did not.
+        
+        Fix by computing the new frame using roundedIntRect(), and using that to determine
+        whether the geometry changed.
+
+        No way to test DidLayout notifications in DRT/WTR.
+
+        * rendering/RenderWidget.cpp:
+        (WebCore::RenderWidget::setWidgetGeometry):
+
 2013-02-21  Jeffrey Pfau  <jpfau@apple.com>
 

trunk/Source/WebCore/rendering/RenderWidget.cpp

@@ -144 +144 @@
 
     IntRect clipRect = roundedIntRect(enclosingLayer()->childrenClipRect());
+    IntRect newFrame = roundedIntRect(frame);
     bool clipChanged = m_clipRect != clipRect;
-    bool boundsChanged = m_widget->frameRect() != frame;
+    bool boundsChanged = m_widget->frameRect() != newFrame;
 
     if (!boundsChanged && !clipChanged)
@@ -154 +155 @@
     RenderWidgetProtector protector(this);
     RefPtr<Node> protectedNode(node());
-    m_widget->setFrameRect(roundedIntRect(frame));
+    m_widget->setFrameRect(newFrame);
     
 #if USE(ACCELERATED_COMPOSITING)