Changeset 144021 in webkit

Timestamp:

Feb 26, 2013, 1:04:57 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r144016.
​http://trac.webkit.org/changeset/144016
​https://bugs.webkit.org/show_bug.cgi?id=110856

Breaks compilation on chromium mac (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-26

Source/WebCore:

• platform/chromium/KeyCodeConversionGtk.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

Source/WebKit/chromium:

• WebKit.gypi:
• tests/KeyCodeConversionTest.cpp: Removed.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/chromium/KeyCodeConversionGtk.cpp (modified) (2 diffs)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/WebKit.gypi (modified) (1 diff)
• WebKit/chromium/tests/KeyCodeConversionTest.cpp (deleted)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r144016.
+        http://trac.webkit.org/changeset/144016
+        https://bugs.webkit.org/show_bug.cgi?id=110856
+
+        Breaks compilation on chromium mac (Requested by vsevik on
+        #webkit).
+
+        * platform/chromium/KeyCodeConversionGtk.cpp:
+        (WebCore::windowsKeyCodeForKeyEvent):
+
 2013-02-26  Glenn Adams  <glenn@skynav.com>
 

trunk/Source/WebCore/platform/chromium/KeyCodeConversionGtk.cpp

@@ -89 +89 @@
     case GDK_KP_Down:
         return VKEY_DOWN; // (28) DOWN ARROW key
-    case GDK_KP_Begin:
-        return VKEY_CLEAR; // (12) CLEAR key
-    case GDK_KP_Insert:
-        return VKEY_INSERT; // (45) INS key
-    case GDK_KP_Delete:
-        return VKEY_DELETE; // (46) DEL key
 
     case GDK_BackSpace:
@@ -121 +115 @@
         return VKEY_LMENU; // (A4) Left ALT key
     case GDK_Alt_R:
-    case GDK_ISO_Level3_Shift:
         return VKEY_RMENU; // (A5) Right ALT key
 

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2013-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r144016.
+        http://trac.webkit.org/changeset/144016
+        https://bugs.webkit.org/show_bug.cgi?id=110856
+
+        Breaks compilation on chromium mac (Requested by vsevik on
+        #webkit).
+
+        * WebKit.gypi:
+        * tests/KeyCodeConversionTest.cpp: Removed.
+
 2013-02-26  James Robinson  <jamesr@chromium.org>
 

trunk/Source/WebKit/chromium/WebKit.gypi

@@ -87 +87 @@
             'tests/MockImageDecoder.h',
             'tests/KeyboardTest.cpp',
-            'tests/KeyCodeConversionTest.cpp',
             'tests/KURLTest.cpp',
             'tests/LevelDBTest.cpp',