Changeset 144077 in webkit

Timestamp:

Feb 26, 2013 10:55:12 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Fix the atomicIncrement implementation for MIPS GCC
​https://bugs.webkit.org/show_bug.cgi?id=106739

Patch by Balazs Kilvady <​kilvadyb@homejinni.com> on 2013-02-26
Reviewed by Oliver Hunt.

Implementation of missing sync_[add|sub]_and_fetch_8 functions.

Some architectures, like MIPS32, don't have GCC implementation for
builtin sync_* functions with 64 bits variable size. GCC answer
for the problem: If a target doesn't support atomic operations on
certain variable sizes, you are out of luck with atomicity in that
case (​http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56296). GCC >= 4.8
will support atomic_* builtin functions for this purpose for all
the GCC targets, but for current compilers we have to include our
own implementation.

• GNUmakefile.list.am:
• WTF.pro:
• wtf/Atomics.cpp: Added.

(WTF):
(WTF::getSwapLock):
(WTF::atomicStep):

• wtf/CMakeLists.txt:

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• GNUmakefile.list.am (modified) (1 diff)
• WTF.pro (modified) (1 diff)
• wtf/Atomics.cpp (added)
• wtf/CMakeLists.txt (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2013-02-26  Balazs Kilvady  <kilvadyb@homejinni.com>
+
+        Fix the atomicIncrement implementation for MIPS GCC
+        https://bugs.webkit.org/show_bug.cgi?id=106739
+
+        Reviewed by Oliver Hunt.
+
+        Implementation of missing __sync_[add|sub]_and_fetch_8 functions.
+
+        Some architectures, like MIPS32, don't have GCC implementation for
+        builtin __sync_* functions with 64 bits variable size. GCC answer
+        for the problem: If a target doesn't support atomic operations on
+        certain variable sizes, you are out of luck with atomicity in that
+        case (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56296). GCC >= 4.8
+        will support __atomic_* builtin functions for this purpose for all
+        the GCC targets, but for current compilers we have to include our
+        own implementation.
+
+        * GNUmakefile.list.am:
+        * WTF.pro:
+        * wtf/Atomics.cpp: Added.
+        (WTF):
+        (WTF::getSwapLock):
+        (WTF::atomicStep):
+        * wtf/CMakeLists.txt:
+
 2013-02-26  Oliver Hunt  <oliver@apple.com>
 

trunk/Source/WTF/GNUmakefile.list.am

@@ -12 +12 @@
     Source/WTF/wtf/Assertions.cpp \
     Source/WTF/wtf/Assertions.h \
+    Source/WTF/wtf/Atomics.cpp \
     Source/WTF/wtf/Atomics.h \
     Source/WTF/wtf/BitArray.h \

trunk/Source/WTF/WTF.pro

@@ -198 +198 @@
     ArrayBufferView.cpp \
     Assertions.cpp \
+    Atomics.cpp \
     BitVector.cpp \
     CryptographicallyRandomNumber.cpp \

trunk/Source/WTF/wtf/CMakeLists.txt

@@ -160 +160 @@
     ArrayBufferView.cpp
     Assertions.cpp
+    Atomics.cpp
     BitVector.cpp
     CryptographicallyRandomNumber.cpp