Changeset 144170 in webkit

Timestamp:

Feb 27, 2013 4:09:18 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r137994): It made JSC tests hang and layout tests fail on ARM Thumb2 / Linux
​https://bugs.webkit.org/show_bug.cgi?id=108632

Patch by Simon Hausmann <​simon.hausmann@digia.com> on 2013-02-27
Reviewed by Csaba Osztrogonác.

It appears that mprotect() is very slow on ARM/Linux, so disable the
approach of unreserved mappings there and fall back to overcomitting
memory, based on Uli Schlachter's recommendation.

• wtf/OSAllocatorPosix.cpp:

(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::decommit):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/OSAllocatorPosix.cpp (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2013-02-27  Simon Hausmann  <simon.hausmann@digia.com>
+
+        REGRESSION(r137994): It made JSC tests hang and layout tests fail on ARM Thumb2 / Linux
+        https://bugs.webkit.org/show_bug.cgi?id=108632
+
+        Reviewed by Csaba Osztrogonác.
+
+        It appears that mprotect() is very slow on ARM/Linux, so disable the
+        approach of unreserved mappings there and fall back to overcomitting
+        memory, based on Uli Schlachter's recommendation.
+
+        * wtf/OSAllocatorPosix.cpp:
+        (WTF::OSAllocator::reserveUncommitted):
+        (WTF::OSAllocator::decommit):
+
 2013-02-26  Roger Fong  <roger_fong@apple.com>
 

trunk/Source/WTF/wtf/OSAllocatorPosix.cpp

@@ -44 +44 @@
     if (result == MAP_FAILED)
         CRASH();
-#elif OS(LINUX)
+#elif OS(LINUX) && !CPU(ARM)
     UNUSED_PARAM(usage);
     UNUSED_PARAM(writable);
@@ -166 +166 @@
     // Use PROT_NONE and MAP_LAZY to decommit the pages.
     mmap(address, bytes, PROT_NONE, MAP_FIXED | MAP_LAZY | MAP_PRIVATE | MAP_ANON, -1, 0);
-#elif OS(LINUX)
+#elif OS(LINUX) && !CPU(ARM)
     madvise(address, bytes, MADV_DONTNEED);
     if (mprotect(address, bytes, PROT_NONE))