Changeset 144232 in webkit

Timestamp:

Feb 27, 2013 1:23:05 PM (11 years ago)

Author:

abarth@webkit.org

Message:

Threaded HTML parser hits ASSERTION FAILED: this == frameLoader()->activeDocumentLoader()
​https://bugs.webkit.org/show_bug.cgi?id=110937

Reviewed by Darin Adler.

This patch restores the ASSERT behind an ifdef so that we can continue
to get converage from the ASSERT while we investigate why it is
triggering in the threaded parser.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::checkLoadComplete):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/DocumentLoader.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-27  Adam Barth  <abarth@webkit.org>
+
+        Threaded HTML parser hits ASSERTION FAILED: this == frameLoader()->activeDocumentLoader()
+        https://bugs.webkit.org/show_bug.cgi?id=110937
+
+        Reviewed by Darin Adler.
+
+        This patch restores the ASSERT behind an ifdef so that we can continue
+        to get converage from the ASSERT while we investigate why it is
+        triggering in the threaded parser.
+
+        * loader/DocumentLoader.cpp:
+        (WebCore::DocumentLoader::checkLoadComplete):
+
 2013-02-27  Lianghui Chen  <liachen@rim.com>
 

trunk/Source/WebCore/loader/DocumentLoader.cpp

@@ -432 +432 @@
     if (!m_frame || isLoading())
         return;
+#if !ENABLE(THREADED_HTML_PARSER)
+    // This ASSERT triggers with the threaded HTML parser.
+    // See https://bugs.webkit.org/show_bug.cgi?id=110937
+    ASSERT(this == frameLoader()->activeDocumentLoader());
+#endif
     m_frame->document()->domWindow()->finishedLoading();
 }