Changeset 144253 in webkit

Timestamp:

Feb 27, 2013 5:33:44 PM (11 years ago)

Author:

eric@webkit.org

Message:

Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
​https://bugs.webkit.org/show_bug.cgi?id=111021

Reviewed by Dirk Pranke.

The underlying code (which is shared with run-webkit-tests)
already knew how to support this option, it just wasn't exposed
via the run-perf-tests front-end. This patch fixes that.

• Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/performance_tests/perftestsrunner.py (modified) (1 diff)
• Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-02-27  Eric Seidel  <eric@webkit.org>
+
+        Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
+        https://bugs.webkit.org/show_bug.cgi?id=111021
+
+        Reviewed by Dirk Pranke.
+
+        The underlying code (which is shared with run-webkit-tests)
+        already knew how to support this option, it just wasn't exposed
+        via the run-perf-tests front-end.  This patch fixes that.
+
+        * Scripts/webkitpy/performance_tests/perftestsrunner.py:
+        (PerfTestsRunner._parse_args):
+
 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

@@ -125 +125 @@
             optparse.make_option("--profiler", action="store",
                 help="Output per-test profile information, using the specified profiler."),
+            optparse.make_option("--additional-drt-flag", action="append",
+                default=[], help="Additional command line flag to pass to DumpRenderTree "
+                     "Specify multiple times to add multiple flags."),
             ]
         return optparse.OptionParser(option_list=(perf_option_list)).parse_args(args)

trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py

@@ -136 +136 @@
                 '--slave-config-json-path=a/source.json',
                 '--test-results-server=somehost',
+                '--additional-drt-flag=--enable-threaded-parser',
+                '--additional-drt-flag=--awesomesauce',
                 '--debug'])
         self.assertTrue(options.build)
@@ -149 +151 @@
         self.assertEqual(options.slave_config_json_path, 'a/source.json')
         self.assertEqual(options.test_results_server, 'somehost')
+        self.assertEqual(options.additional_drt_flag, ['--enable-threaded-parser', '--awesomesauce'])
 
     def test_upload_json(self):