Changeset 144644 in webkit

Timestamp:

Mar 4, 2013 10:49:29 AM (11 years ago)

Author:

alexis@webkit.org

Message:

transition-property property and transition shorthand property doesn't accept "all, all".
​https://bugs.webkit.org/show_bug.cgi?id=111201

Reviewed by Simon Fraser.

Source/WebCore:

Relax the parsing of transition-property to allow all, all as a value.
It is not very useful per say but it is possible by the spec and we
align with Firefox, IE and Opera.

Test: LayoutTests/transitions/transitions-parsing.html

• css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationProperty):

LayoutTests:

Updated the tests to cover the bug.

• transitions/transitions-parsing-expected.txt:
• transitions/transitions-parsing.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/transitions/transitions-parsing-expected.txt (modified) (4 diffs)
• LayoutTests/transitions/transitions-parsing.html (modified) (4 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSParser.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-03-04  Alexis Menard  <alexis@webkit.org>
+
+        transition-property property and transition shorthand property doesn't accept "all, all".
+        https://bugs.webkit.org/show_bug.cgi?id=111201
+
+        Reviewed by Simon Fraser.
+
+        Updated the tests to cover the bug.
+
+        * transitions/transitions-parsing-expected.txt:
+        * transitions/transitions-parsing.html:
+
 2013-03-04  Ian Vollick  <vollick@chromium.org>
 

trunk/LayoutTests/transitions/transitions-parsing-expected.txt

@@ -16 +16 @@
 PASS computedStyle.transitionProperty is 'all'
 PASS style.webkitTransitionProperty is 'all'
+PASS computedStyle.webkitTransitionProperty is 'all'
+PASS style.transitionProperty is 'all, all'
+PASS computedStyle.transitionProperty is 'all'
+PASS style.webkitTransitionProperty is 'all, all'
 PASS computedStyle.webkitTransitionProperty is 'all'
 PASS style.transitionProperty is 'background-position'
@@ -42 +46 @@
 PASS computedStyle.webkitTransitionProperty is 'font-size, all, color'
 Invalid transition-property values.
-PASS style.transitionProperty is ''
-PASS computedStyle.transitionProperty is 'all'
-PASS style.webkitTransitionProperty is ''
-PASS computedStyle.webkitTransitionProperty is 'all'
 PASS style.transitionProperty is ''
 PASS computedStyle.transitionProperty is 'all'
@@ -396 +396 @@
 PASS computedStyle.webkitTransitionDelay is '10s, 20s'
 PASS checkTransitionShorthandValue() is true
+PASS style.transition is 'all, all'
+PASS computedStyle.transition is 'all 0s ease 0s'
+PASS style.webkitTransition is 'all, all'
+PASS computedStyle.webkitTransition is 'all 0s ease 0s'
+PASS style.transition is 'all 20s ease-in 10s, all 20s ease-out'
+PASS computedStyle.transition is 'all 20s ease-out 0s'
+PASS style.webkitTransition is 'all 20s ease-in 10s, all 20s ease-out'
+PASS computedStyle.webkitTransition is 'all 20s ease-out 0s'
 PASS style.transition is 'opacity 20s ease-in 10s, all 20s ease-out'
 PASS computedStyle.transition is 'opacity 20s ease-in 10s, all 20s ease-out 0s'
@@ -459 +467 @@
 PASS style.webkitTransition is ''
 PASS computedStyle.webkitTransition is 'all 0s ease 0s'
-PASS style.transition is ''
-PASS computedStyle.transition is 'all 0s ease 0s'
-PASS style.webkitTransition is ''
-PASS computedStyle.webkitTransition is 'all 0s ease 0s'
 PASS successfullyParsed is true
 

trunk/LayoutTests/transitions/transitions-parsing.html

@@ -44 +44 @@
 shouldBe("computedStyle.webkitTransitionProperty", "'all'");
 
+style.transitionProperty = "all, all";
+shouldBe("style.transitionProperty", "'all, all'");
+shouldBe("computedStyle.transitionProperty", "'all'");
+shouldBe("style.webkitTransitionProperty", "'all, all'");
+shouldBe("computedStyle.webkitTransitionProperty", "'all'");
+
 style.transitionProperty = "background-position";
 shouldBe("style.transitionProperty", "'background-position'");
@@ -156 +162 @@
 
 style.transitionProperty = "none, width";
-shouldBe("style.transitionProperty", "''");
-shouldBe("computedStyle.transitionProperty", "'all'");
-shouldBe("style.webkitTransitionProperty", "''");
-shouldBe("computedStyle.webkitTransitionProperty", "'all'");
-
-style.transitionProperty = "all, all";
 shouldBe("style.transitionProperty", "''");
 shouldBe("computedStyle.transitionProperty", "'all'");
@@ -624 +624 @@
 shouldBe("checkTransitionShorthandValue()", "true");
 
+style.transition = "all, all";
+shouldBe("style.transition", "'all, all'");
+shouldBe("computedStyle.transition", "'all 0s ease 0s'");
+shouldBe("style.webkitTransition", "'all, all'");
+shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
+
+style.transition = "all 20s 10s ease-in, all ease-out 20s";
+shouldBe("style.transition", "'all 20s ease-in 10s, all 20s ease-out'");
+shouldBe("computedStyle.transition", "'all 20s ease-out 0s'");
+shouldBe("style.webkitTransition", "'all 20s ease-in 10s, all 20s ease-out'");
+shouldBe("computedStyle.webkitTransition", "'all 20s ease-out 0s'");
+
 style.transition = "ease-in opacity 20s 10s, all ease-out 20s";
 shouldBe("style.transition", "'opacity 20s ease-in 10s, all 20s ease-out'");
@@ -719 +731 @@
 shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
 
-style.transition = "all, all";
-shouldBe("style.transition", "''");
-shouldBe("computedStyle.transition", "'all 0s ease 0s'");
-shouldBe("style.webkitTransition", "''");
-shouldBe("computedStyle.webkitTransition", "'all 0s ease 0s'");
-
 document.body.removeChild(testContainer);
 </script>

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-04  Alexis Menard  <alexis@webkit.org>
+
+        transition-property property and transition shorthand property doesn't accept "all, all".
+        https://bugs.webkit.org/show_bug.cgi?id=111201
+
+        Reviewed by Simon Fraser.
+
+        Relax the parsing of transition-property to allow all, all as a value.
+        It is not very useful per say but it is possible by the spec and we
+        align with Firefox, IE and Opera.
+
+        Test: LayoutTests/transitions/transitions-parsing.html
+
+        * css/CSSParser.cpp:
+        (WebCore::CSSParser::parseAnimationProperty):
+
 2013-03-04  Min Qin  <qinmin@chromium.org>
 

trunk/Source/WebCore/css/CSSParser.cpp

@@ -4446 +4446 @@
         return cssValuePool().createIdentifierValue(result);
     if (equalIgnoringCase(value, "all")) {
-        if (context.hasSeenAnimationPropertyKeyword())
-            context.commitAnimationPropertyKeyword();
         context.sawAnimationPropertyKeyword();
         return cssValuePool().createIdentifierValue(CSSValueAll);