Changeset 144771 in webkit
- Timestamp:
- Mar 5, 2013 9:54:31 AM (11 years ago)
- Location:
- trunk/Source/WebKit/blackberry
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/blackberry/ChangeLog
r144750 r144771 1 2013-03-05 Tiancheng Jiang <tijiang@rim.com> 2 3 [BlackBerry] FatFinger pairs the wrong element with fatfinger rect part. 4 https://bugs.webkit.org/show_bug.cgi?id=111444 5 6 Reviewed by Rob Buis. 7 8 Internal PR 266214 9 Internally reviewed by Genevieve Mak. 10 11 Instead of subtracting with the element region, we should get the remaining 12 rect by find the intersect region of element region and fatfinger detection 13 region. 14 15 16 * WebKitSupport/FatFingers.cpp: 17 (BlackBerry::WebKit::FatFingers::checkForClickableElement): 18 1 19 2013-03-05 Andrew Lo <anlo@rim.com> 2 20 -
trunk/Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp
r143933 r144771 375 375 376 376 // elementRegion will always be in contents coordinates of its container frame. It needs to be 377 // mapped to main frame contents coordinates in order to subtract the fingerRegion, then.377 // mapped to main frame contents coordinates in order to intersect the fingerRegion, then. 378 378 WebCore::IntPoint framePos(m_webPage->frameOffset(curElement->document()->frame())); 379 379 IntRectRegion layerRegion(Platform::IntRect(lowestPositionedEnclosingLayerSoFar->renderer()->absoluteBoundingBoxRect(true/*use transforms*/))); 380 380 layerRegion.move(framePos.x(), framePos.y()); 381 381 382 remainingFingerRegion = subtractRegions(remainingFingerRegion, layerRegion);382 remainingFingerRegion = intersectRegions(remainingFingerRegion, layerRegion); 383 383 384 384 lowestPositionedEnclosingLayerSoFar = curElementRenderLayer;
Note: See TracChangeset
for help on using the changeset viewer.