Changeset 144785 in webkit

Timestamp:

Mar 5, 2013 11:07:26 AM (11 years ago)

Author:

eric@webkit.org

Message:

Add html-parser-threaded perf test now that the threaded parser is enabled by default
​https://bugs.webkit.org/show_bug.cgi?id=111200

Reviewed by Ryosuke Niwa.

PerformanceTests:

The old srcdoc test no longer triggers the threaded parser due to compatibility fixes.

• Parser/html-parser-threaded.html: Renamed from PerformanceTests/Parser/html-parser-srcdoc.html.
• Skipped: Unfortunately this new test is still skipped too.

Tools:

Had to teach run-perf-tests to ignore one more warning.

• Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest):

Location:

trunk

Files:

• PerformanceTests/ChangeLog (modified) (1 diff)
• PerformanceTests/Parser/html-parser-threaded.html (moved) (moved from trunk/PerformanceTests/Parser/html-parser-srcdoc.html) (2 diffs)
• PerformanceTests/Skipped (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/webkitpy/performance_tests/perftest.py (modified) (1 diff)

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2013-03-05  Eric Seidel  <eric@webkit.org>
+
+        Add html-parser-threaded perf test now that the threaded parser is enabled by default
+        https://bugs.webkit.org/show_bug.cgi?id=111200
+
+        Reviewed by Ryosuke Niwa.
+
+        The old srcdoc test no longer triggers the threaded parser due to compatibility fixes.
+
+        * Parser/html-parser-threaded.html: Renamed from PerformanceTests/Parser/html-parser-srcdoc.html.
+        * Skipped: Unfortunately this new test is still skipped too.
+
 2013-03-04  Eric Seidel  <eric@webkit.org>
 

trunk/PerformanceTests/Parser/html-parser-threaded.html

@@ -7 +7 @@
     window.internals.settings.setThreadedHTMLParser(true);
 
-var spec = PerfTestRunner.loadFile("resources/html5.html");
+var specURL = "resources/html5.html";
 
 var iframe = document.createElement("iframe");
@@ -20 +20 @@
     PerfTestRunner.measureValueAsync(now - then);
     then = now;
-    iframe.srcdoc = spec;
+    iframe.src = specURL;
 }
 var then = PerfTestRunner.now();
-iframe.srcdoc = spec;
+iframe.src = specURL;
 
 function onCompletedRun() {

trunk/PerformanceTests/Skipped

@@ -72 +72 @@
 Canvas/drawimage.html
 
-# Works fine, but is mostly useful to the threaded-parsing folks, as
-# it's very similar to parser/html-parser.html just using
-# srcdoc to load instead of document.write.
-Parser/html-parser-srcdoc.html
+# Has a time-dependency (monotonically increasing), and is much slower than
+# necessary due to https://bugs.webkit.org/show_bug.cgi?id=107236
+# but is still useful for testing the threaded parser.
+Parser/html-parser-threaded.html

trunk/Tools/ChangeLog

@@ +1 @@
+2013-03-05  Eric Seidel  <eric@webkit.org>
+
+        Add html-parser-threaded perf test now that the threaded parser is enabled by default
+        https://bugs.webkit.org/show_bug.cgi?id=111200
+
+        Reviewed by Ryosuke Niwa.
+
+        Had to teach run-perf-tests to ignore one more warning.
+
+        * Scripts/webkitpy/performance_tests/perftest.py:
+        (PerfTest):
+
 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
 

trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py

@@ -247 +247 @@
         re.compile(re.escape("""Blocked access to external URL http://www.whatwg.org/specs/web-apps/current-work/""")),
         re.compile(r"CONSOLE MESSAGE: (line \d+: )?Blocked script execution in '[A-Za-z0-9\-\.:]+' because the document's frame is sandboxed and the 'allow-scripts' permission is not set."),
+        re.compile(r"CONSOLE MESSAGE: (line \d+: )?Not allowed to load local resource"),
         # Dromaeo reports values for subtests. Ignore them for now.
         re.compile(r'(?P<name>.+): \[(?P<values>(\d+(.\d+)?,\s+)*\d+(.\d+)?)\]'),