Changeset 144789 in webkit


Ignore:
Timestamp:
Mar 5, 2013 11:37:18 AM (11 years ago)
Author:
scherkus@chromium.org
Message:

REGRESSION(r142191): Fix closed caption buttons for ports still using the painting path.
​https://bugs.webkit.org/show_bug.cgi?id=111109

Reviewed by Eric Carlson.

Source/WebCore:

Covered by following tests:
media/track/track-cue-rendering-horizontal.html
media/track/track-cue-rendering-vertical.html

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton):

LayoutTests:

  • platform/chromium/TestExpectations:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r144776 r144789  
     12013-03-04  Andrew Scherkus  <scherkus@chromium.org>
     2
     3        REGRESSION(r142191): Fix closed caption buttons for ports still using the painting path.
     4        https://bugs.webkit.org/show_bug.cgi?id=111109
     5
     6        Reviewed by Eric Carlson.
     7
     8        * platform/chromium/TestExpectations:
     9
    1102013-03-05  Bem Jones-Bey  <bjonesbe@adobe.com>
    211

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r144748 r144789  
    44144414webkit.org/b/109769 [ Mac ] fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html [ Failure ]
    44154415webkit.org/b/109769 [ Mac ] fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html [ Failure ]
     4416
     4417# Current baselines are incorrect -- needs rebaseline after webkit.org/b/111388 lands.
     4418webkit.org/b/111388 media/track/track-cue-rendering-horizontal.html [ ImageOnlyFailure ]
     4419webkit.org/b/111388 media/track/track-cue-rendering-vertical.html [ ImageOnlyFailure ]

  • trunk/Source/WebCore/ChangeLog

    r144787 r144789  
     12013-03-04  Andrew Scherkus  <scherkus@chromium.org>
     2
     3        REGRESSION(r142191): Fix closed caption buttons for ports still using the painting path.
     4        https://bugs.webkit.org/show_bug.cgi?id=111109
     5
     6        Reviewed by Eric Carlson.
     7
     8        Covered by following tests:
     9        media/track/track-cue-rendering-horizontal.html
     10        media/track/track-cue-rendering-vertical.html
     11
     12        * rendering/RenderTheme.cpp:
     13        (WebCore::RenderTheme::paint):
     14        * rendering/RenderTheme.h:
     15        (WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton):
     16
    1172013-03-05  Gwang Yoon Hwang  <ryumiel@company100.net>
    218

  • trunk/Source/WebCore/rendering/RenderTheme.cpp

    r143398 r144789  
    342342    case MediaReturnToRealtimeButtonPart:
    343343        return paintMediaReturnToRealtimeButton(o, paintInfo, r);
     344    case MediaToggleClosedCaptionsButtonPart:
     345        return paintMediaToggleClosedCaptionsButton(o, paintInfo, r);
    344346    case MediaSliderPart:
    345347        return paintMediaSliderTrack(o, paintInfo, r);

  • trunk/Source/WebCore/rendering/RenderTheme.h

    r142191 r144789  
    339339    virtual bool paintMediaRewindButton(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
    340340    virtual bool paintMediaReturnToRealtimeButton(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
     341    virtual bool paintMediaToggleClosedCaptionsButton(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
    341342    virtual bool paintMediaControlsBackground(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
    342343    virtual bool paintMediaCurrentTime(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
Note: See TracChangeset for help on using the changeset viewer.