Changeset 144901 in webkit


Ignore:
Timestamp:
Mar 6, 2013 1:59:22 AM (11 years ago)
Author:
allan.jensen@digia.com
Message:

REGGRESSION (r142112): It made compositing tests fail on EFL, Qt.
​https://bugs.webkit.org/show_bug.cgi?id=109291

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Report we support fixed layers.

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:

(WebCore::ScrollingCoordinatorCoordinatedGraphics::supportsFixedPositionLayers):
(ScrollingCoordinatorCoordinatedGraphics):

LayoutTests:

Unskip now passing test, and move baselines specific to having no scrolling-coordinator to WK1.

  • platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png.
  • platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt.
  • platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png.
  • platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt.
  • platform/qt-5.0-wk2/TestExpectations:
Location:
trunk
Files:
1 added
4 edited
4 moved

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r144897 r144901  
     12013-03-06  Allan Sandfeld Jensen  <allan.jensen@digia.com>
     2
     3        REGGRESSION (r142112): It made compositing tests fail on EFL, Qt.
     4        https://bugs.webkit.org/show_bug.cgi?id=109291
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Unskip now passing test, and move baselines specific to having no scrolling-coordinator to WK1.
     9
     10        * platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png.
     11        * platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt.
     12        * platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png.
     13        * platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt.
     14        * platform/qt-5.0-wk2/TestExpectations:
     15
    1162013-03-06  Hayato Ito  <hayato@chromium.org>
    217

  • trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations

    r144752 r144901  
    375375webkit.org/b/109291 compositing/iframes/iframe-composited-scrolling.html
    376376webkit.org/b/109291 compositing/layer-creation/fixed-position-in-view-dynamic.html
    377 webkit.org/b/109291 compositing/layer-creation/fixed-position-out-of-view-dynamic.html
    378 webkit.org/b/109291 compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html
    379 webkit.org/b/109291 compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html
    380 webkit.org/b/109291 scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
    381 webkit.org/b/109291 scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html
    382377
    383378# [Qt] [WK2] Some fullscreen layout tests are timing out on the bot

  • trunk/Source/WebCore/ChangeLog

    r144896 r144901  
     12013-03-06  Allan Sandfeld Jensen  <allan.jensen@digia.com>
     2
     3        REGGRESSION (r142112): It made compositing tests fail on EFL, Qt.
     4        https://bugs.webkit.org/show_bug.cgi?id=109291
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        Report we support fixed layers.
     9
     10        * page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
     11        (WebCore::ScrollingCoordinatorCoordinatedGraphics::supportsFixedPositionLayers):
     12        (ScrollingCoordinatorCoordinatedGraphics):
     13
    1142013-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
    215

  • trunk/Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h

    r142143 r144901  
    3737    explicit ScrollingCoordinatorCoordinatedGraphics(Page*);
    3838
     39    virtual bool supportsFixedPositionLayers() const { return true; }
     40
    3941    virtual void setLayerIsFixedToContainerLayer(GraphicsLayer*, bool);
    4042};
Note: See TracChangeset for help on using the changeset viewer.