Changeset 144938 in webkit

Timestamp:

Mar 6, 2013 9:39:37 AM (11 years ago)

Author:

Csaba Osztrogonác

Message:

Fix unused parameter warnings in ARM assembler
​https://bugs.webkit.org/show_bug.cgi?id=111433

Reviewed by Kentaro Hara.

• assembler/ARMAssembler.h: Remove unreachable revertJump() after r143346.
• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::moveIntsToDouble): Remove unused scratch parameter instead of UNUSED_PARAM.
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32): Remove unused fpTemp parameter.
(JSC::MacroAssemblerARM::revertJumpReplacementToPatchableBranchPtrWithPatch): Remove unused parameters.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/ARMAssembler.h (modified) (1 diff)
• assembler/MacroAssemblerARM.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-03-06  Csaba Osztrogonác  <ossy@webkit.org>
+
+        Fix unused parameter warnings in ARM assembler
+        https://bugs.webkit.org/show_bug.cgi?id=111433
+
+        Reviewed by Kentaro Hara.
+
+        * assembler/ARMAssembler.h: Remove unreachable revertJump() after r143346.
+        * assembler/MacroAssemblerARM.h:
+        (JSC::MacroAssemblerARM::moveIntsToDouble): Remove unused scratch parameter instead of UNUSED_PARAM.
+        (JSC::MacroAssemblerARM::branchConvertDoubleToInt32): Remove unused fpTemp parameter.
+        (JSC::MacroAssemblerARM::revertJumpReplacementToPatchableBranchPtrWithPatch): Remove unused parameters.
+
 2013-03-06  Andreas Kling  <akling@apple.com>
 

trunk/Source/JavaScriptCore/assembler/ARMAssembler.h

@@ -403 +403 @@
         }
 
-        static void revertJump(void* instructionStart, RegisterID rd, ARMWord imm)
-        {
-            ARMWord* insn = reinterpret_cast<ARMWord*>(instructionStart);
-            ARMWord* address = getLdrImmAddress(insn);
-            *address = imm;
-        }
-
         void bic(int rd, int rn, ARMWord op2, Condition cc = AL)
         {

trunk/Source/JavaScriptCore/assembler/MacroAssemblerARM.h

@@ -674 +674 @@
     }
 
-    void moveIntsToDouble(RegisterID src1, RegisterID src2, FPRegisterID dest, FPRegisterID scratch)
-    {
-        UNUSED_PARAM(scratch);
+    void moveIntsToDouble(RegisterID src1, RegisterID src2, FPRegisterID dest, FPRegisterID)
+    {
         m_assembler.vmov(dest, src1, src2);
     }
@@ -1243 +1242 @@
     // May also branch for some values that are representable in 32 bits
     // (specifically, in this case, 0).
-    void branchConvertDoubleToInt32(FPRegisterID src, RegisterID dest, JumpList& failureCases, FPRegisterID fpTemp)
+    void branchConvertDoubleToInt32(FPRegisterID src, RegisterID dest, JumpList& failureCases, FPRegisterID)
     {
         m_assembler.vcvt_s32_f64(ARMRegisters::SD0 << 1, src);
@@ -1316 +1315 @@
     }
 
-    static void revertJumpReplacementToPatchableBranchPtrWithPatch(CodeLocationLabel instructionStart, Address, void* initialValue)
+    static void revertJumpReplacementToPatchableBranchPtrWithPatch(CodeLocationLabel, Address, void*)
     {
         UNREACHABLE_FOR_PLATFORM();