Changeset 144943 in webkit

Timestamp:

Mar 6, 2013 10:11:24 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Link the webkit_tests to XRENDER_LIBS.
This solves the linking failure when building against gtk2 like:
usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
Source/WebCore/platform/gtk/Programs_unittests_testcopyandpaste-GtkVersioning.o:
undefined reference to symbol 'XFree'
/usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
note: 'XFree' is defined in DSO /usr/lib/libX11.so.6 so try adding it
to the linker command line
/usr/lib/libX11.so.6: could not read symbols: Invalid operation

​https://bugs.webkit.org/show_bug.cgi?id=111572

Patch by Dominique Leuenberger <​dimstar@opensuse.org> on 2013-03-06
Reviewed by Gustavo Noronha Silva.

• GNUmakefile.am:

Location:

trunk/Source/WebKit/gtk

Files:

• ChangeLog (modified) (1 diff)
• GNUmakefile.am (modified) (1 diff)

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2013-03-06  Dominique Leuenberger  <dimstar@opensuse.org>
+
+        Link the webkit_tests to XRENDER_LIBS.
+        This solves the linking failure when building against gtk2 like:
+        usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
+        Source/WebCore/platform/gtk/Programs_unittests_testcopyandpaste-GtkVersioning.o:
+        undefined reference to symbol 'XFree'
+        /usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
+        note: 'XFree' is defined in DSO /usr/lib/libX11.so.6 so try adding it
+        to the linker command line
+        /usr/lib/libX11.so.6: could not read symbols: Invalid operation
+
+        https://bugs.webkit.org/show_bug.cgi?id=111572
+
+        Reviewed by Gustavo Noronha Silva.
+
+        * GNUmakefile.am:
+
 2013-03-03  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebKit/gtk/GNUmakefile.am

@@ -450 +450 @@
         $(GTK_LIBS) \
         $(GLIB_LIBS) \
-        $(LIBSOUP_LIBS)
+        $(LIBSOUP_LIBS) \
+        $(XRENDER_LIBS)
 
 webkit_tests_ldflags = \