Changeset 144972 in webkit


Ignore:
Timestamp:
Mar 6, 2013 1:21:48 PM (11 years ago)
Author:
tonyg@chromium.org
Message:

Threaded HTML parser should use 8 bit strings for attributes
https://bugs.webkit.org/show_bug.cgi?id=111610

Reviewed by Eric Seidel.

This fixes a 27% regression in dromaeo_jslibattrjquery on the threaded HTML parser vs. the main thread parser.

No new tests because no new functionality.

  • html/parser/CompactHTMLToken.cpp:

(WebCore::CompactHTMLToken::CompactHTMLToken):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r144961 r144972  
     12013-03-06  Tony Gentilcore  <tonyg@chromium.org>
     2
     3        Threaded HTML parser should use 8 bit strings for attributes
     4        https://bugs.webkit.org/show_bug.cgi?id=111610
     5
     6        Reviewed by Eric Seidel.
     7
     8        This fixes a 27% regression in dromaeo_jslibattrjquery on the threaded HTML parser vs. the main thread parser.
     9
     10        No new tests because no new functionality.
     11
     12        * html/parser/CompactHTMLToken.cpp:
     13        (WebCore::CompactHTMLToken::CompactHTMLToken):
     14
    1152013-03-06  Alpha Lam  <hclam@chromium.org>
    216
  • trunk/Source/WebCore/html/parser/CompactHTMLToken.cpp

    r144801 r144972  
    6868    case HTMLToken::StartTag:
    6969        m_attributes.reserveInitialCapacity(token->attributes().size());
    70         // FIXME: Attribute names and values should be 8bit when possible.
    7170        for (Vector<HTMLToken::Attribute>::const_iterator it = token->attributes().begin(); it != token->attributes().end(); ++it)
    72             m_attributes.append(Attribute(String(it->name), String(it->value)));
     71            m_attributes.append(Attribute(StringImpl::create8BitIfPossible(it->name), StringImpl::create8BitIfPossible(it->value)));
    7372        // Fall through!
    7473    case HTMLToken::EndTag:
Note: See TracChangeset for help on using the changeset viewer.