Changeset 145202 in webkit

Timestamp:

Mar 8, 2013 2:40:10 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Memory leak in webkit_web_view_load_request() in WebKit2 API
​https://bugs.webkit.org/show_bug.cgi?id=111160

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-03-08
Reviewed by Benjamin Poulain.

leakRef() is used for the returned PassRefPtr without taking the
ownership of the leaked ref.

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_request): Use RefPtr local variable.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/WebKitWebView.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Memory leak in webkit_web_view_load_request() in WebKit2 API
+        https://bugs.webkit.org/show_bug.cgi?id=111160
+
+        Reviewed by Benjamin Poulain.
+
+        leakRef() is used for the returned PassRefPtr without taking the
+        ownership of the leaked ref.
+
+        * UIProcess/API/gtk/WebKitWebView.cpp:
+        (webkit_web_view_load_request): Use RefPtr local variable.
+
 2013-03-07  Huang Dongsung  <luxtella@company100.net>
 

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp

@@ -1822 +1822 @@
     g_return_if_fail(WEBKIT_IS_URI_REQUEST(request));
 
-    getPage(webView)->loadURLRequest(WebURLRequest::create(webkitURIRequestGetResourceRequest(request)).leakRef());
+    RefPtr<WebURLRequest> urlRequest = WebURLRequest::create(webkitURIRequestGetResourceRequest(request));
+    getPage(webView)->loadURLRequest(urlRequest.get());
 }