Changeset 145207 in webkit

Timestamp:

Mar 8, 2013 3:25:47 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL][Qt] REGRESSION(r144787): A fixed element lags when scrolling and wheeling.
​https://bugs.webkit.org/show_bug.cgi?id=111829

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-03-08
Reviewed by Noam Rosenthal.

Currently, flagsChanged deals with all boolean flags. It introduces this bug
because when another flag (i.e. preserves3D) is changed, fixedToViewport is set
to false. So this patch updates all flags when at least one flag is changed.

In addition, this patch amends isScrollable code to match other flags.

This patch can only be tested manually since there is no automated
testing facilities for in-motion touch.
Test: ManualTests/fixed-position.html

ManualTests/nested-fixed-position.html

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setScrollableArea):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::setLayerState):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp (modified) (2 diffs)
• platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp (modified) (1 diff)
• platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-08  Huang Dongsung  <luxtella@company100.net>
+
+        [EFL][Qt] REGRESSION(r144787): A fixed element lags when scrolling and wheeling.
+        https://bugs.webkit.org/show_bug.cgi?id=111829
+
+        Reviewed by Noam Rosenthal.
+
+        Currently, flagsChanged deals with all boolean flags. It introduces this bug
+        because when another flag (i.e. preserves3D) is changed, fixedToViewport is set
+        to false. So this patch updates all flags when at least one flag is changed.
+
+        In addition, this patch amends isScrollable code to match other flags.
+
+        This patch can only be tested manually since there is no automated
+        testing facilities for in-motion touch.
+        Test: ManualTests/fixed-position.html
+              ManualTests/nested-fixed-position.html
+
+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
+        (WebCore::CoordinatedGraphicsLayer::setScrollableArea):
+        (WebCore::CoordinatedGraphicsLayer::syncLayerState):
+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
+        (WebCore::CoordinatedGraphicsScene::setLayerState):
+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
+        (WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):
+
 2013-03-07  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp

@@ -525 +525 @@
 
     m_layerState.isScrollable = isScrollable();
-    m_layerState.isScrollableChanged = true;
+    m_layerState.flagsChanged = true;
     didChangeLayerState();
 }
@@ -645 +645 @@
     m_layerState.pos = m_adjustedPosition;
     m_layerState.size = m_adjustedSize;
+
+    if (m_layerState.flagsChanged) {
+        m_layerState.drawsContent = drawsContent();
+        m_layerState.contentsVisible = contentsAreVisible();
+        m_layerState.backfaceVisible = backfaceVisibility();
+        m_layerState.masksToBounds = masksToBounds();
+        m_layerState.preserves3D = preserves3D();
+        m_layerState.fixedToViewport = fixedToViewport();
+        m_layerState.showDebugBorders = isShowingDebugBorder();
+        m_layerState.showRepaintCounter = isShowingRepaintCounter();
+        m_layerState.isScrollable = isScrollable();
+    }
 
     if (m_layerState.showDebugBorders)

trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp

@@ -356 +356 @@
         layer->setPreserves3D(layerState.preserves3D);
 
+        bool fixedToViewportChanged = toGraphicsLayerTextureMapper(layer)->fixedToViewport() != layerState.fixedToViewport;
         toGraphicsLayerTextureMapper(layer)->setFixedToViewport(layerState.fixedToViewport);
+        if (fixedToViewportChanged) {
+            if (layerState.fixedToViewport)
+                m_fixedLayers.add(id, layer);
+            else
+                m_fixedLayers.remove(id);
+        }
+
         layer->setShowDebugBorder(layerState.showDebugBorders);
         layer->setShowRepaintCounter(layerState.showRepaintCounter);
-    }
-
-    if (layerState.isScrollableChanged)
+
         toGraphicsLayerTextureMapper(layer)->setIsScrollable(layerState.isScrollable);
+    }
 
     if (layerState.committedScrollOffsetChanged)
         toGraphicsLayerTextureMapper(layer)->didCommitScrollOffset(layerState.committedScrollOffset);
-
-    if (layerState.fixedToViewport)
-        m_fixedLayers.add(id, layer);
-    else
-        m_fixedLayers.remove(id);
 
     prepareContentBackingStore(layer);

trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h

@@ -125 +125 @@
         , showDebugBorders(false)
         , showRepaintCounter(false)
+        , isScrollable(false)
         , opacity(0)
         , debugBorderWidth(0)