Changeset 145329 in webkit
- Timestamp:
- Mar 10, 2013 12:16:38 PM (11 years ago)
- Location:
- trunk/Source/JavaScriptCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r145323 r145329 1 2013-03-10 Andreas Kling <akling@apple.com> 2 3 SpeculativeJIT should use OwnPtr<SlowPathGenerator>. 4 <http://webkit.org/b/111942> 5 6 Reviewed by Anders Carlsson. 7 8 There's no need to include DFGSlowPathGenerator.h from the header as long as the destructor is out-of-line, 9 so let's use OwnPtr instead of raw pointers + deleteAllValues(). 10 11 * dfg/DFGSpeculativeJIT.cpp: 12 (JSC::DFG::SpeculativeJIT::~SpeculativeJIT): 13 (JSC::DFG::SpeculativeJIT::addSlowPathGenerator): 14 * dfg/DFGSpeculativeJIT.h: 15 (SpeculativeJIT): 16 1 17 2013-03-09 Sheriff Bot <webkit.review.bot@gmail.com> 2 18 -
trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
r144886 r145329 57 57 SpeculativeJIT::~SpeculativeJIT() 58 58 { 59 WTF::deleteAllValues(m_slowPathGenerators);60 59 } 61 60 … … 345 344 void SpeculativeJIT::addSlowPathGenerator(PassOwnPtr<SlowPathGenerator> slowPathGenerator) 346 345 { 347 m_slowPathGenerators.append(slowPathGenerator .leakPtr());346 m_slowPathGenerators.append(slowPathGenerator); 348 347 } 349 348 -
trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h
r144886 r145329 2299 2299 bool m_isCheckingArgumentTypes; 2300 2300 2301 Vector< SlowPathGenerator*, 8> m_slowPathGenerators; // doesn't use OwnPtr<> because I don't want to include DFGSlowPathGenerator.h2301 Vector<OwnPtr<SlowPathGenerator>, 8> m_slowPathGenerators; 2302 2302 Vector<SilentRegisterSavePlan> m_plans; 2303 2303
Note: See TracChangeset
for help on using the changeset viewer.