Changeset 145347 in webkit

Timestamp:

Mar 11, 2013 2:40:08 AM (11 years ago)

Author:

silviapf@chromium.org

Message:

[Chromium] REGRESSION: Closed Captions button not showing properly
​https://bugs.webkit.org/show_bug.cgi?id=109871

Reviewed by Jer Noble.

No new tests - covered by existing tests.

Most of the patch was in the meantime covered by a patch to
​https://bugs.webkit.org/show_bug.cgi?id=111109 .
This changes a static Chromium-only function name to be consistent with
parent class function names.

• rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaToggleClosedCaptionsButton):
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
Rename paintMediaClosedCaptionsButton to paintMediaToggleClosedCaptionsButton.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderMediaControlsChromium.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-11  Silvia Pfeiffer  <silviapf@chromium.org>
+
+        [Chromium] REGRESSION: Closed Captions button not showing properly
+        https://bugs.webkit.org/show_bug.cgi?id=109871
+
+        Reviewed by Jer Noble.
+
+        No new tests - covered by existing tests.
+
+        Most of the patch was in the meantime covered by a patch to
+        https://bugs.webkit.org/show_bug.cgi?id=111109 .
+        This changes a static Chromium-only function name to be consistent with
+        parent class function names.
+
+        * rendering/RenderMediaControlsChromium.cpp:
+        (WebCore::paintMediaToggleClosedCaptionsButton):
+        (WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
+        Rename paintMediaClosedCaptionsButton to paintMediaToggleClosedCaptionsButton.
+
 2013-03-11  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/rendering/RenderMediaControlsChromium.cpp

@@ -328 +328 @@
 }
 
-static bool paintMediaClosedCaptionsButton(RenderObject* object, const PaintInfo& paintInfo, const IntRect& rect)
+static bool paintMediaToggleClosedCaptionsButton(RenderObject* object, const PaintInfo& paintInfo, const IntRect& rect)
 {
     HTMLMediaElement* mediaElement = toParentMediaElement(object);
@@ -354 +354 @@
         return paintMediaPlayButton(object, paintInfo, rect);
     case MediaShowClosedCaptionsButton:
-        return paintMediaClosedCaptionsButton(object, paintInfo, rect);
+        return paintMediaToggleClosedCaptionsButton(object, paintInfo, rect);
     case MediaSlider:
         return paintMediaSlider(object, paintInfo, rect);