Changeset 145868 in webkit


Ignore:
Timestamp:
Mar 14, 2013 7:41:26 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

plugins/plugin-clip-subframe.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=112324

Patch by John Bauman <​jbauman@chromium.org> on 2013-03-14
Reviewed by Ryosuke Niwa.

Ignore duplicate SetWindow calls with identical arguments. Plugins
will ignore these so they're not a problem, and they can cause
flakiness on mac-wk2.

  • platform/chromium-linux/plugins/plugin-clip-subframe-expected.txt:
  • platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt:
  • platform/chromium-win/plugins/plugin-clip-subframe-expected.txt:
  • platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt:
  • platform/mac/plugins/plugin-clip-subframe-expected.txt:
  • plugins/plugin-clip-subframe-expected.txt:
  • plugins/resources/plugin-clip-subframe-iframe.html:
Location:
trunk/LayoutTests
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r145866 r145868  
     12013-03-14  John Bauman  <jbauman@chromium.org>
     2
     3        plugins/plugin-clip-subframe.html is flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=112324
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Ignore duplicate SetWindow calls with identical arguments. Plugins
     9        will ignore these so they're not a problem, and they can cause
     10        flakiness on mac-wk2.
     11
     12        * platform/chromium-linux/plugins/plugin-clip-subframe-expected.txt:
     13        * platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt:
     14        * platform/chromium-win/plugins/plugin-clip-subframe-expected.txt:
     15        * platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt:
     16        * platform/mac/plugins/plugin-clip-subframe-expected.txt:
     17        * plugins/plugin-clip-subframe-expected.txt:
     18        * plugins/resources/plugin-clip-subframe-iframe.html:
     19
    1202013-03-14  Chris Fleizach  <cfleizach@apple.com>
    221

  • trunk/LayoutTests/platform/chromium-linux/plugins/plugin-clip-subframe-expected.txt

    r144256 r145868  
    1 CONSOLE MESSAGE: line 3: NPP_SetWindow: non-NULL window, Rect {18, 218, 300, 150}, Clip Rect {65518, 65318, 65518, 65318}, Type 1
    2 CONSOLE MESSAGE: line 3: NPP_SetWindow: non-NULL window, Rect {18, 218, 300, 150}, Clip Rect {0, 0, 90, 150}, Type 1
     1CONSOLE MESSAGE: line 5: NPP_SetWindow: non-NULL window, Rect {18, 218, 300, 150}, Clip Rect {65518, 65318, 65518, 65318}, Type 1
     2CONSOLE MESSAGE: line 5: NPP_SetWindow: non-NULL window, Rect {18, 218, 300, 150}, Clip Rect {0, 0, 90, 150}, Type 1
    33

  • trunk/LayoutTests/platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt

    r145794 r145868  
    1 CONSOLE MESSAGE: line 3: NPP_SetWindow: NULL window, Rect {0, 0, 300, 150}, Clip Rect {65518, 65318, 65518, 65318}, Type 2
    2 CONSOLE MESSAGE: line 3: NPP_SetWindow: NULL window, Rect {0, 0, 300, 150}, Clip Rect {0, 0, 90, 150}, Type 2
     1CONSOLE MESSAGE: line 5: NPP_SetWindow: NULL window, Rect {0, 0, 300, 150}, Clip Rect {65518, 65318, 65518, 65318}, Type 2
     2CONSOLE MESSAGE: line 5: NPP_SetWindow: NULL window, Rect {0, 0, 300, 150}, Clip Rect {0, 0, 90, 150}, Type 2
    33

  • trunk/LayoutTests/platform/chromium-win/plugins/plugin-clip-subframe-expected.txt

    r144251 r145868  
    1 CONSOLE MESSAGE: line 3: NPP_SetWindow: non-NULL window, Rect {0, 0, 300, 150}, Clip Rect {0, 0, 0, 0}, Type 1
    2 CONSOLE MESSAGE: line 3: NPP_SetWindow: non-NULL window, Rect {0, 0, 300, 150}, Clip Rect {0, 0, 90, 150}, Type 1
     1CONSOLE MESSAGE: line 5: NPP_SetWindow: non-NULL window, Rect {0, 0, 300, 150}, Clip Rect {0, 0, 0, 0}, Type 1
     2CONSOLE MESSAGE: line 5: NPP_SetWindow: non-NULL window, Rect {0, 0, 300, 150}, Clip Rect {0, 0, 90, 150}, Type 1
    33

  • trunk/LayoutTests/platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt

    r144236 r145868  
    1 CONSOLE MESSAGE: line 3: NPP_SetWindow: NULL window, Rect {0, 0, 300, 150}, Clip Rect {0, 0, 0, 0}, Type 2
    2 CONSOLE MESSAGE: line 3: NPP_SetWindow: NULL window, Rect {0, 0, 300, 150}, Clip Rect {0, 0, 0, 0}, Type 2
    3 CONSOLE MESSAGE: line 3: NPP_SetWindow: NULL window, Rect {0, 0, 300, 150}, Clip Rect {0, 0, 300, 150}, Type 2
     1CONSOLE MESSAGE: line 5: NPP_SetWindow: NULL window, Rect {0, 0, 300, 150}, Clip Rect {0, 0, 0, 0}, Type 2
     2CONSOLE MESSAGE: line 5: NPP_SetWindow: NULL window, Rect {0, 0, 300, 150}, Clip Rect {0, 0, 300, 150}, Type 2
    43

  • trunk/LayoutTests/platform/mac/plugins/plugin-clip-subframe-expected.txt

    r144236 r145868  
    1 CONSOLE MESSAGE: line 3: NPP_SetWindow: NULL window, Rect {18, 218, 300, 150}, Clip Rect {0, 600, 0, 600}, Type 0
    2 CONSOLE MESSAGE: line 3: NPP_SetWindow: NULL window, Rect {18, 218, 300, 150}, Clip Rect {18, 218, 108, 368}, Type 0
     1CONSOLE MESSAGE: line 5: NPP_SetWindow: NULL window, Rect {18, 218, 300, 150}, Clip Rect {0, 600, 0, 600}, Type 0
     2CONSOLE MESSAGE: line 5: NPP_SetWindow: NULL window, Rect {18, 218, 300, 150}, Clip Rect {18, 218, 108, 368}, Type 0
    33

  • trunk/LayoutTests/plugins/plugin-clip-subframe-expected.txt

    r144236 r145868  
    1 CONSOLE MESSAGE: line 3: NPP_SetWindow: non-NULL window, Rect {18, 218, 300, 150}, Clip Rect {65518, 65318, 65518, 65318}, Type 1
    2 CONSOLE MESSAGE: line 3: NPP_SetWindow: non-NULL window, Rect {18, 218, 300, 150}, Clip Rect {0, 0, 90, 150}, Type 1
     1CONSOLE MESSAGE: line 5: NPP_SetWindow: non-NULL window, Rect {18, 218, 300, 150}, Clip Rect {65518, 65318, 65518, 65318}, Type 1
     2CONSOLE MESSAGE: line 5: NPP_SetWindow: non-NULL window, Rect {18, 218, 300, 150}, Clip Rect {0, 0, 90, 150}, Type 1
    33

  • trunk/LayoutTests/plugins/resources/plugin-clip-subframe-iframe.html

    r144236 r145868  
    11<script>
     2var lastMessage;
    23function windowWasSet(msg) {
    3     console.log(msg);
     4    if (msg != lastMessage)
     5        console.log(msg);
     6    lastMessage = msg;
    47}
    58</script>
    69
    710<embed id="testCPlugin" type="application/x-webkit-test-netscape" test="log-npp-set-window"></embed>
     11<div id="output"></div>
Note: See TracChangeset for help on using the changeset viewer.