Changeset 146098 in webkit

Timestamp:

Mar 18, 2013 12:04:37 PM (11 years ago)

Author:

jchaffraix@webkit.org

Message:

[CSS Grid Layout] Fix StyleGridData::operator==
​https://bugs.webkit.org/show_bug.cgi?id=112574

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-auto-flow-update.html

• rendering/style/StyleGridData.h:

(WebCore::StyleGridData::operator==):
Fixed a bad comparison that would make us ignore grid-auto-flow changes.

LayoutTests:

• fast/css-grid-layout/grid-auto-flow-update-expected.txt: Added.
• fast/css-grid-layout/grid-auto-flow-update.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css-grid-layout/grid-auto-flow-update-expected.txt (added)
• LayoutTests/fast/css-grid-layout/grid-auto-flow-update.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/style/StyleGridData.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-03-18  Julien Chaffraix  <jchaffraix@webkit.org>
+
+        [CSS Grid Layout] Fix StyleGridData::operator==
+        https://bugs.webkit.org/show_bug.cgi?id=112574
+
+        Reviewed by Ojan Vafai.
+
+        * fast/css-grid-layout/grid-auto-flow-update-expected.txt: Added.
+        * fast/css-grid-layout/grid-auto-flow-update.html: Added.
+
 2013-03-18  Kenneth Russell  <kbr@google.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-18  Julien Chaffraix  <jchaffraix@webkit.org>
+
+        [CSS Grid Layout] Fix StyleGridData::operator==
+        https://bugs.webkit.org/show_bug.cgi?id=112574
+
+        Reviewed by Ojan Vafai.
+
+        Test: fast/css-grid-layout/grid-auto-flow-update.html
+
+        * rendering/style/StyleGridData.h:
+        (WebCore::StyleGridData::operator==):
+        Fixed a bad comparison that would make us ignore grid-auto-flow changes.
+
 2013-03-18  Rafael Weinstein  <rafaelw@chromium.org>
 

trunk/Source/WebCore/rendering/style/StyleGridData.h

@@ -42 +42 @@
     bool operator==(const StyleGridData& o) const
     {
-        return m_gridColumns == o.m_gridColumns && m_gridRows == o.m_gridRows && m_gridAutoFlow != o.m_gridAutoFlow;
+        return m_gridColumns == o.m_gridColumns && m_gridRows == o.m_gridRows && m_gridAutoFlow == o.m_gridAutoFlow;
     }