Changeset 146210 in webkit

Timestamp:

Mar 19, 2013 9:06:42 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Fix heap profiler performance tests.
​https://bugs.webkit.org/show_bug.cgi?id=112701

Patch by Alexei Filippov <​alph@chromium.org> on 2013-03-19
Reviewed by Yury Semikhatsky.

The tests were broken by profile types refactoring.

• inspector/heap-snapshot-performance-test.js:

(test.performanceTest.step0):
(test.performanceTest.step1):

Location:

trunk/PerformanceTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/heap-snapshot-performance-test.js (modified) (2 diffs)

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2013-03-19  Alexei Filippov  <alph@chromium.org>
+
+        Web Inspector: Fix heap profiler performance tests.
+        https://bugs.webkit.org/show_bug.cgi?id=112701
+
+        Reviewed by Yury Semikhatsky.
+
+        The tests were broken by profile types refactoring.
+
+        * inspector/heap-snapshot-performance-test.js:
+        (test.performanceTest.step0):
+        (test.performanceTest.step1):
+
 2013-03-05  Eric Seidel  <eric@webkit.org>
 

trunk/PerformanceTests/inspector/heap-snapshot-performance-test.js

@@ -34 +34 @@
             timer.finish(backendTimerCookie);
             transferTimerCookie = timer.start("transfer-snapshot");
-            var profiles = WebInspector.panels.profiles.getProfiles("HEAP");
+            var type = WebInspector.panels.profiles.getProfileType("HEAP");
+            var profiles = type.getProfiles();
             WebInspector.panels.profiles._showProfile(profiles[profiles.length - 1]);
-            InspectorTest.addSniffer(WebInspector.panels.profiles, "_finishHeapSnapshot", step1);
+            InspectorTest.addSniffer(type, "finishHeapSnapshot", step1);
         }
 
@@ -44 +45 @@
             showTimerCookie = timer.start("show-snapshot");
             var panel = WebInspector.panels.profiles;
-            var profile = panel._profilesIdMap[panel._makeKey(uid, WebInspector.HeapSnapshotProfileType.TypeId)];
+            var profile = panel.getProfile("HEAP", uid);
             profile.load(step2); // Add load callback.
         }