Changeset 146324 in webkit


Ignore:
Timestamp:
Mar 20, 2013 4:22:14 AM (11 years ago)
Author:
allan.jensen@digia.com
Message:

[Qt] Support -webkit-font-smoothing
https://bugs.webkit.org/show_bug.cgi?id=106009

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Set QFont antialiasing settings based on the font smoothing settings in FontDescription.

  • platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):

Source/WebKit/qt:

Export an interface so DRT can also disable font-smoothing like WTR does.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setShouldUseFontSmoothing):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Set shouldUseFontSmoothing to false to match WebKitTestRunner.

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::reset):

Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r146319 r146324  
     12013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
     2
     3        [Qt] Support -webkit-font-smoothing
     4        https://bugs.webkit.org/show_bug.cgi?id=106009
     5
     6        Reviewed by Jocelyn Turcotte.
     7
     8        Set QFont antialiasing settings based on the font smoothing settings in FontDescription.
     9
     10        * platform/graphics/qt/FontPlatformDataQt.cpp:
     11        (WebCore::FontPlatformData::FontPlatformData):
     12
    1132013-03-20  Alexei Filippov  <alph@chromium.org>
    214
  • trunk/Source/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp

    r146203 r146324  
    33    Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/
    44    Copyright (C) 2011 Nokia Corporation and/or its subsidiary(-ies)
     5    Copyright (C) 2013 Digia Plc. and/or its subsidiary(-ies)
    56
    67    This library is free software; you can redistribute it and/or
     
    2425#include "FontPlatformData.h"
    2526
     27#include "Font.h"
    2628#include <wtf/text/WTFString.h>
    2729
     
    7375    font.setLetterSpacing(QFont::AbsoluteSpacing, letterSpacing);
    7476#if QT_VERSION < QT_VERSION_CHECK(5, 1, 0)
    75     // Kept enabled for Qt < 5.1 to maintain stable baselines for 5.0.
     77    // To maintain stable baselines for Qt 5.0, keep force integer metrics enabled and ignore font-smoothing setting.
    7678    font.setStyleStrategy(QFont::ForceIntegerMetrics);
     79#else
     80    if (description.fontSmoothing() == NoSmoothing
     81        || (description.fontSmoothing() == AutoSmoothing && !Font::shouldUseSmoothing()))
     82        font.setStyleStrategy(QFont::NoAntialias);
    7783#endif
    7884
  • trunk/Source/WebKit/qt/ChangeLog

    r145914 r146324  
     12013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
     2
     3        [Qt] Support -webkit-font-smoothing
     4        https://bugs.webkit.org/show_bug.cgi?id=106009
     5
     6        Reviewed by Jocelyn Turcotte.
     7
     8        Export an interface so DRT can also disable font-smoothing like WTR does.
     9
     10        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
     11        (DumpRenderTreeSupportQt::setShouldUseFontSmoothing):
     12        * WebCoreSupport/DumpRenderTreeSupportQt.h:
     13
    1142013-03-15  Nate Chapin  <japhet@chromium.org>
    215
  • trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp

    r145849 r146324  
    3939#include "Element.h"
    4040#include "FocusController.h"
     41#include "Font.h"
    4142#include "Frame.h"
    4243#include "FrameLoadRequest.h"
     
    873874}
    874875
     876void DumpRenderTreeSupportQt::setShouldUseFontSmoothing(bool enabled)
     877{
     878    WebCore::Font::setShouldUseSmoothing(enabled);
     879}
     880
    875881QString DumpRenderTreeSupportQt::frameRenderTreeDump(QWebFrameAdapter* adapter)
    876882{
  • trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h

    r145849 r146324  
    200200
    201201    static void setSeamlessIFramesEnabled(bool);
     202    static void setShouldUseFontSmoothing(bool);
    202203
    203204    static QString frameRenderTreeDump(QWebFrameAdapter*);
  • trunk/Tools/ChangeLog

    r146312 r146324  
     12013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
     2
     3        [Qt] Support -webkit-font-smoothing
     4        https://bugs.webkit.org/show_bug.cgi?id=106009
     5
     6        Reviewed by Jocelyn Turcotte.
     7
     8        Set shouldUseFontSmoothing to false to match WebKitTestRunner.
     9
     10        * DumpRenderTree/qt/TestRunnerQt.cpp:
     11        (TestRunnerQt::reset):
     12
    1132013-03-20  Krzysztof Czech  <k.czech@samsung.com>
    214
  • trunk/Tools/DumpRenderTree/qt/TestRunnerQt.cpp

    r145940 r146324  
    8989    DumpRenderTreeSupportQt::resetGeolocationMock(m_drt->pageAdapter());
    9090    DumpRenderTreeSupportQt::dumpNotification(false);
     91    DumpRenderTreeSupportQt::setShouldUseFontSmoothing(false);
    9192    setIconDatabaseEnabled(false);
    9293    clearAllDatabases();
Note: See TracChangeset for help on using the changeset viewer.