Changeset 146556 in webkit

Timestamp:

Mar 21, 2013 8:02:18 PM (11 years ago)

Author:

tasak@google.com

Message:

[Shadow]: @host styles are not applied dynamically
​https://bugs.webkit.org/show_bug.cgi?id=112869

Reviewed by Elliott Sprehn.

Source/WebCore:

Need to add features of @host @-rules to rule feature set.

Test: fast/dom/shadow/athost-apply-dynamically.html

• css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::collectFeaturesTo):

LayoutTests:

• fast/dom/shadow/athost-apply-dynamically-expected.html: Added.
• fast/dom/shadow/athost-apply-dynamically.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/shadow/athost-apply-dynamically-expected.html (added)
• LayoutTests/fast/dom/shadow/athost-apply-dynamically.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/StyleScopeResolver.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-03-21  Takashi Sakamoto  <tasak@google.com>
+
+        [Shadow]: @host styles are not applied dynamically
+        https://bugs.webkit.org/show_bug.cgi?id=112869
+
+        Reviewed by Elliott Sprehn.
+
+        * fast/dom/shadow/athost-apply-dynamically-expected.html: Added.
+        * fast/dom/shadow/athost-apply-dynamically.html: Added.
+
 2013-03-21  Hayato Ito  <hayato@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-21  Takashi Sakamoto  <tasak@google.com>
+
+        [Shadow]: @host styles are not applied dynamically
+        https://bugs.webkit.org/show_bug.cgi?id=112869
+
+        Reviewed by Elliott Sprehn.
+
+        Need to add features of @host @-rules to rule feature set.
+
+        Test: fast/dom/shadow/athost-apply-dynamically.html
+
+        * css/StyleScopeResolver.cpp:
+        (WebCore::StyleScopeResolver::collectFeaturesTo):
+
 2013-03-21  Hayato Ito  <hayato@chromium.org>
 

trunk/Source/WebCore/css/StyleScopeResolver.cpp

@@ -156 +156 @@
     for (ScopedRuleSetMap::iterator it = m_authorStyles.begin(); it != m_authorStyles.end(); ++it)
         features.add(it->value->features());
+#if ENABLE(SHADOW_DOM)
+    for (ScopedRuleSetMap::iterator it = m_atHostRules.begin(); it != m_atHostRules.end(); ++it)
+        features.add(it->value->features());
+#endif
 }