Changeset 146858 in webkit

Timestamp:

Mar 26, 2013 1:20:18 AM (11 years ago)

Author:

loislo@chromium.org

Message:

Web Inspector: [FlameChart] Make function bar highlighted consistent with cursor.
​https://bugs.webkit.org/show_bug.cgi?id=113266.

Patch by Pan Deng <​pan.deng@intel.com> on 2013-03-26
Reviewed by Vsevolod Vlasov.

In Flamechart, the highlighted function bar is not consistent with cursor sometimes,
reason is that time range that converted from cursor position is truncated by floor.
Actually float value is expected to compare with function startTime and duration.

No new tests.

• inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.prototype._coordinatesToNodeIndex): Remove floor

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/FlameChart.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-26  Pan Deng  <pan.deng@intel.com>
+
+        Web Inspector: [FlameChart] Make function bar highlighted consistent with cursor.
+        https://bugs.webkit.org/show_bug.cgi?id=113266.
+
+        Reviewed by Vsevolod Vlasov.
+
+        In Flamechart, the highlighted function bar is not consistent with cursor sometimes, 
+        reason is that time range that converted from cursor position is truncated by floor. 
+        Actually float value is expected to compare with function startTime and duration.
+
+        No new tests.
+
+        * inspector/front-end/FlameChart.js:
+        (WebInspector.FlameChart.prototype._coordinatesToNodeIndex): Remove floor
+
 2013-03-26  Mihnea Ovidenie  <mihnea@adobe.com>
 

trunk/Source/WebCore/inspector/front-end/FlameChart.js

@@ -452 +452 @@
             return -1;
         var timelineEntries = timelineData.entries;
-        var cursorTime = Math.floor((x + this._pixelWindowLeft) * this._pixelToTime);
+        var cursorTime = (x + this._pixelWindowLeft) * this._pixelToTime;
         var cursorLevel = Math.floor((this._canvas.height - y) / this._barHeight);