Changeset 146890 in webkit


Ignore:
Timestamp:
Mar 26, 2013 8:54:21 AM (11 years ago)
Author:
loislo@chromium.org
Message:

Web Inspector: Flame Chart. Scroll dividers together with underlying chart.
http://bugs.webkit.org/show_bug.cgi?id=113080

Reviewed by Pavel Feldman.

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.Calculator.prototype.grandMinimumBoundary):
(WebInspector.FlameChart.prototype._canvasDragging):

  • inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):

Location:
trunk/Source/WebCore
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r146886 r146890  
     12013-03-22  Ilya Tikhonovsky  <loislo@chromium.org>
     2
     3        Web Inspector: Flame Chart. Scroll dividers together with underlying chart.
     4        http://bugs.webkit.org/show_bug.cgi?id=113080
     5
     6        Reviewed by Pavel Feldman.
     7
     8        * inspector/front-end/FlameChart.js:
     9        (WebInspector.FlameChart.Calculator.prototype.grandMinimumBoundary):
     10        (WebInspector.FlameChart.prototype._canvasDragging):
     11        * inspector/front-end/TimelineGrid.js:
     12        (WebInspector.TimelineGrid.prototype.updateDividers):
     13
     142013-03-26  Ilya Tikhonovsky  <loislo@chromium.org>
     15
     16        Web Inspector: Flame Chart. Scroll dividers together with underlying chart.
     17        http://bugs.webkit.org/show_bug.cgi?id=113080
     18
     19        Reviewed by Pavel Feldman.
     20
     21        The only thing we need to do for this feature is to automatically adjust
     22        the initial offset for the dividers. I measured the speed of scrolling and found
     23        no difference. The speed is about 16ms so we have 60fps on dragging.
     24
     25        * inspector/front-end/FlameChart.js:
     26        (WebInspector.FlameChart.Calculator.prototype.grandMinimumBoundary):
     27        (WebInspector.FlameChart.OverviewCalculator.prototype.grandMinimumBoundary):
     28        (WebInspector.FlameChart.prototype._canvasDragging):
     29        * inspector/front-end/NetworkPanel.js:
     30        (WebInspector.NetworkBaseCalculator.prototype.grandMinimumBoundary):
     31        * inspector/front-end/TimelineGrid.js:
     32        (WebInspector.TimelineGrid.prototype.updateDividers):
     33        (WebInspector.TimelineGrid.Calculator.prototype.grandMinimumBoundary):
     34        * inspector/front-end/TimelineOverviewPane.js:
     35        (WebInspector.TimelineOverviewCalculator.prototype.grandMinimumBoundary):
     36        * inspector/front-end/TimelinePanel.js:
     37        (WebInspector.TimelineCalculator.prototype.grandMinimumBoundary):
     38
    1392013-03-26  Mike West  <mkwst@chromium.org>
    240
  • trunk/Source/WebCore/inspector/front-end/FlameChart.js

    r146858 r146890  
    114114    },
    115115
     116    grandMinimumBoundary: function()
     117    {
     118        return 0;
     119    },
     120
    116121    boundarySpan: function()
    117122    {
     
    158163
    159164    minimumBoundary: function()
     165    {
     166        return this._minimumBoundaries;
     167    },
     168
     169    grandMinimumBoundary: function()
    160170    {
    161171        return this._minimumBoundaries;
     
    205215            return;
    206216        windowShift = windowRight - this._dragStartWindowRight;
    207 
    208217        this._overviewGrid.setWindow(this._dragStartWindowLeft + windowShift, this._dragStartWindowRight + windowShift);
    209218    },
  • trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

    r146325 r146890  
    17891789
    17901790    minimumBoundary: function()
     1791    {
     1792        return this._minimumBoundary;
     1793    },
     1794
     1795    grandMinimumBoundary: function()
    17911796    {
    17921797        return this._minimumBoundary;
  • trunk/Source/WebCore/inspector/front-end/TimelineGrid.js

    r144453 r146890  
    9191
    9292        var paddingLeft = calculator.paddingLeft;
     93        var sliceRemainder = (calculator.minimumBoundary() - calculator.grandMinimumBoundary()) % slice;
    9394        for (var i = paddingLeft ? 0 : 1; i <= dividerCount; ++i) {
    9495            if (!divider) {
     
    127128                dividerLabelBar._labelElement.textContent = "";
    128129            } else {
    129                 left = calculator.computePosition(calculator.minimumBoundary() + slice * i);
    130                 dividerLabelBar._labelElement.textContent = calculator.formatTime(slice * i);
     130                left = calculator.computePosition(calculator.minimumBoundary() + slice * i - sliceRemainder);
     131                dividerLabelBar._labelElement.textContent = calculator.formatTime(slice * i - sliceRemainder);
    131132            }
    132133            var percentLeft = 100 * left / dividersElementClientWidth;
     
    232233
    233234    /** @return {number} */
     235    grandMinimumBoundary: function() { },
     236
     237    /** @return {number} */
    234238    maximumBoundary: function() { },
    235239
  • trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js

    r146354 r146890  
    402402    },
    403403
     404    grandMinimumBoundary: function()
     405    {
     406        return this._minimumBoundary;
     407    },
     408
    404409    boundarySpan: function()
    405410    {
  • trunk/Source/WebCore/inspector/front-end/TimelinePanel.js

    r146771 r146890  
    13551355    },
    13561356
     1357    grandMinimumBoundary: function()
     1358    {
     1359        return this._minimumBoundary;
     1360    },
     1361
    13571362    boundarySpan: function()
    13581363    {
Note: See TracChangeset for help on using the changeset viewer.