Changeset 146899 in webkit

Timestamp:

Mar 26, 2013 10:04:52 AM (11 years ago)

Author:

Christophe Dumez

Message:

HTTPHeaderMap::copyData() could call uncheckedAppend()
​https://bugs.webkit.org/show_bug.cgi?id=113279

Reviewed by Alexey Proskuryakov.

HTTPHeaderMap::copyData() calls reserveInitialCapacity() on the Vector
but then appends items using append() function. Since we already know
the capacity is sufficient, it is more efficient to call uncheckedAppend()
instead to bypass capacity checks.

No new tests, no behavior change for layout tests.

• platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/HTTPHeaderMap.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-26  Christophe Dumez  <ch.dumez@sisa.samsung.com>
+
+        HTTPHeaderMap::copyData() could call uncheckedAppend()
+        https://bugs.webkit.org/show_bug.cgi?id=113279
+
+        Reviewed by Alexey Proskuryakov.
+
+        HTTPHeaderMap::copyData() calls reserveInitialCapacity() on the Vector
+        but then appends items using append() function. Since we already know
+        the capacity is sufficient, it is more efficient to call uncheckedAppend()
+        instead to bypass capacity checks.
+
+        No new tests, no behavior change for layout tests.
+
+        * platform/network/HTTPHeaderMap.cpp:
+        (WebCore::HTTPHeaderMap::copyData):
+
 2013-03-26  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/platform/network/HTTPHeaderMap.cpp

@@ -52 +52 @@
 
     HTTPHeaderMap::const_iterator end_it = end();
-    for (HTTPHeaderMap::const_iterator it = begin(); it != end_it; ++it) {
-        data->append(make_pair(it->key.string().isolatedCopy(), it->value.isolatedCopy()));
-    }
+    for (HTTPHeaderMap::const_iterator it = begin(); it != end_it; ++it)
+        data->uncheckedAppend(make_pair(it->key.string().isolatedCopy(), it->value.isolatedCopy()));
+
     return data.release();
 }