Changeset 146969 in webkit

Timestamp:

Mar 27, 2013 12:31:20 AM (11 years ago)

Author:

loislo@chromium.org

Message:

Web Inspector: Timeline. Scroll dividers with the underlying events.
​https://bugs.webkit.org/show_bug.cgi?id=113315

Reviewed by Pavel Feldman.

Now when TimelineGrid is able to draw dividers with any offset
we could cut away paddingLeft member of Timeline.Calculator
and clear the code of TimelineGrid.

• inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):

• inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelineCalculator.prototype.computePosition):
(WebInspector.TimelineCalculator.prototype.setDisplayWindow):
(WebInspector.TimelineCalculator.prototype.grandMinimumBoundary):

• inspector/front-end/inspectorCommon.css:

(.resources-dividers-label-bar):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TimelineGrid.js (modified) (3 diffs)
• inspector/front-end/TimelinePanel.js (modified) (4 diffs)
• inspector/front-end/inspectorCommon.css (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-26  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Web Inspector: Timeline. Scroll dividers with the underlying events.
+        https://bugs.webkit.org/show_bug.cgi?id=113315
+
+        Reviewed by Pavel Feldman.
+
+        Now when TimelineGrid is able to draw dividers with any offset
+        we could cut away paddingLeft member of Timeline.Calculator
+        and clear the code of TimelineGrid.
+
+        * inspector/front-end/TimelineGrid.js:
+        (WebInspector.TimelineGrid.prototype.updateDividers):
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel.prototype._refresh):
+        (WebInspector.TimelineCalculator.prototype.computePosition):
+        (WebInspector.TimelineCalculator.prototype.setDisplayWindow):
+        (WebInspector.TimelineCalculator.prototype.grandMinimumBoundary):
+        * inspector/front-end/inspectorCommon.css:
+        (.resources-dividers-label-bar):
+
 2013-03-27  Kondapally Kalyan  <kalyan.kondapally@intel.com>
 

trunk/Source/WebCore/inspector/front-end/TimelineGrid.js

@@ -90 +90 @@
         var dividerLabelBar = this._dividersLabelBarElement.firstChild;
 
-        var paddingLeft = calculator.paddingLeft;
         var sliceRemainder = (calculator.minimumBoundary() - calculator.grandMinimumBoundary()) % slice;
-        for (var i = paddingLeft ? 0 : 1; i <= dividerCount; ++i) {
+        for (var i = 0; i <= dividerCount; ++i) {
             if (!divider) {
                 divider = document.createElement("div");
@@ -107 +106 @@
             }
 
-            if (i === (paddingLeft ? 0 : 1)) {
+            if (!i) {
                 divider.addStyleClass("first");
                 dividerLabelBar.addStyleClass("first");
@@ -125 +124 @@
             var left;
             if (!slice) {
-                left = dividersElementClientWidth / dividerCount * i + paddingLeft;
+                left = dividersElementClientWidth / dividerCount * i;
                 dividerLabelBar._labelElement.textContent = "";
             } else {

trunk/Source/WebCore/inspector/front-end/TimelinePanel.js

@@ -785 +785 @@
         }
 
-        this._timelinePaddingLeft = !this._overviewPane.windowLeft() ? this._expandOffset : 0;
+        this._timelinePaddingLeft = this._expandOffset;
         this._calculator.setWindow(this._overviewPane.windowStartTime(), this._overviewPane.windowEndTime());
         this._calculator.setDisplayWindow(this._timelinePaddingLeft, this._graphRowsElementWidth);
@@ -1293 +1293 @@
     computePosition: function(time)
     {
-        return (time - this._minimumBoundary) / this.boundarySpan() * this._workingArea + this.paddingLeft;
+        return (time - this._minimumBoundary) / this.boundarySpan() * this._workingArea + this._paddingLeft;
     },
 
@@ -1337 +1337 @@
     {
         this._workingArea = clientWidth - WebInspector.TimelineCalculator._minWidth - paddingLeft;
-        this.paddingLeft = paddingLeft;
+        this._paddingLeft = paddingLeft;
     },
 
@@ -1357 +1357 @@
     grandMinimumBoundary: function()
     {
-        return this._minimumBoundary;
+        return this._model.minimumRecordTime();
     },
 

trunk/Source/WebCore/inspector/front-end/inspectorCommon.css

@@ -92 +92 @@
     pointer-events: none;
     cursor: move;
+    overflow: hidden;
 }