Changeset 147025 in webkit

Timestamp:

Mar 27, 2013, 5:05:17 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: [DTE] paint overlay highlight for unhighlighted lines
​https://bugs.webkit.org/show_bug.cgi?id=113344

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-27
Reviewed by Pavel Feldman.

No new tests.

Remove fast-return condition from paintLine method that checked for
highlight existence.

• inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._paintLine):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/DefaultTextEditor.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-27  Andrey Lushnikov  <lushnikov@chromium.org>
+
+        Web Inspector: [DTE] paint overlay highlight for unhighlighted lines
+        https://bugs.webkit.org/show_bug.cgi?id=113344
+
+        Reviewed by Pavel Feldman.
+
+        No new tests.
+
+        Remove fast-return condition from paintLine method that checked for
+        highlight existence.
+
+        * inspector/front-end/DefaultTextEditor.js:
+        (WebInspector.TextEditorMainPanel.prototype._paintLine):
+
 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/inspector/front-end/DefaultTextEditor.js

@@ -2112 +2112 @@
         try {
             var syntaxHighlight = this._textModel.getAttribute(lineNumber, "highlight");
-            if (!syntaxHighlight)
-                return;
 
             var line = this._textModel.line(lineNumber);
-            var ranges = syntaxHighlight.ranges;
+            var ranges = syntaxHighlight ? syntaxHighlight.ranges : [];
             this._renderRanges(lineRow, line, ranges, this._showWhitespace);