Changeset 147029 in webkit


Ignore:
Timestamp:
Mar 27, 2013 5:13:12 PM (11 years ago)
Author:
charles.wei@torchmobile.com.cn
Message:

Remove build warning for unused function parameters in indexeddb.
​https://bugs.webkit.org/show_bug.cgi?id=113043

Reviewed by Tony Chang.

No new tests, just remove build warning.

  • Modules/indexeddb/IDBCallbacks.h:

(WebCore::IDBCallbacks::onBlocked):
(WebCore::IDBCallbacks::onUpgradeNeeded):

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::stringToDirection):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::prefetchReset):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setIndexesReady):

  • Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(IDBLevelDBCoding):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore):
(WebCore::IDBObjectStore::openCursor):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::stringToMode):

  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

Location:
trunk/Source/WebCore
Files:
13 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r147028 r147029  
     12013-03-27  Charles Wei  <charles.wei@torchmobile.com.cn>
     2
     3        Remove build warning for unused function parameters in indexeddb.
     4        https://bugs.webkit.org/show_bug.cgi?id=113043
     5
     6        Reviewed by Tony Chang.
     7
     8        No new tests, just remove build warning.
     9
     10        * Modules/indexeddb/IDBCallbacks.h:
     11        (WebCore::IDBCallbacks::onBlocked):
     12        (WebCore::IDBCallbacks::onUpgradeNeeded):
     13        * Modules/indexeddb/IDBCursor.cpp:
     14        (WebCore::IDBCursor::stringToDirection):
     15        * Modules/indexeddb/IDBCursor.h:
     16        (IDBCursor):
     17        * Modules/indexeddb/IDBCursorBackendImpl.cpp:
     18        (WebCore::IDBCursorBackendImpl::prefetchReset):
     19        * Modules/indexeddb/IDBDatabase.cpp:
     20        (WebCore::IDBDatabase::transaction):
     21        * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
     22        (WebCore::IDBDatabaseBackendImpl::setIndexesReady):
     23        * Modules/indexeddb/IDBIndex.cpp:
     24        (WebCore::IDBIndex::openCursor):
     25        (WebCore::IDBIndex::openKeyCursor):
     26        * Modules/indexeddb/IDBLevelDBCoding.cpp:
     27        (IDBLevelDBCoding):
     28        * Modules/indexeddb/IDBObjectStore.cpp:
     29        (WebCore):
     30        (WebCore::IDBObjectStore::openCursor):
     31        * Modules/indexeddb/IDBTransaction.cpp:
     32        (WebCore::IDBTransaction::stringToMode):
     33        * Modules/indexeddb/IDBTransaction.h:
     34        (IDBTransaction):
     35        * inspector/InspectorIndexedDBAgent.cpp:
     36        (WebCore):
     37
    1382013-03-27  Sergey Ryazanov  <serya@chromium.org>
    239

  • trunk/Source/WebCore/Modules/indexeddb/IDBCallbacks.h

    r143694 r147029  
    6969    virtual void onSuccessWithPrefetch(const Vector<RefPtr<IDBKey> >& keys, const Vector<RefPtr<IDBKey> >& primaryKeys, const Vector<RefPtr<SharedBuffer> >& values) = 0;
    7070    // From IDBFactory.open()/deleteDatabase()
    71     virtual void onBlocked(int64_t existingVersion) { ASSERT_NOT_REACHED(); }
     71    virtual void onBlocked(int64_t /* existingVersion */) { ASSERT_NOT_REACHED(); }
    7272    // From IDBFactory.open()
    73     virtual void onUpgradeNeeded(int64_t oldVersion, PassRefPtr<IDBDatabaseBackendInterface>, const IDBDatabaseMetadata&) { ASSERT_NOT_REACHED(); }
     73    virtual void onUpgradeNeeded(int64_t /* oldVersion */, PassRefPtr<IDBDatabaseBackendInterface>, const IDBDatabaseMetadata&) { ASSERT_NOT_REACHED(); }
    7474    virtual void onSuccess(PassRefPtr<IDBDatabaseBackendInterface>, const IDBDatabaseMetadata&) { ASSERT_NOT_REACHED(); }
    7575};

  • trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp

    r145929 r147029  
    298298}
    299299
    300 IndexedDB::CursorDirection IDBCursor::stringToDirection(const String& directionString, ScriptExecutionContext* context, ExceptionCode& ec)
     300IndexedDB::CursorDirection IDBCursor::stringToDirection(const String& directionString, ExceptionCode& ec)
    301301{
    302302    if (directionString == IDBCursor::directionNext())

  • trunk/Source/WebCore/Modules/indexeddb/IDBCursor.h

    r145929 r147029  
    5656    static const AtomicString& directionPrevUnique();
    5757
    58     static IndexedDB::CursorDirection stringToDirection(const String& modeString, ScriptExecutionContext*, ExceptionCode&);
     58    static IndexedDB::CursorDirection stringToDirection(const String& modeString, ExceptionCode&);
    5959    static const AtomicString& directionToString(unsigned short mode);
    6060

  • trunk/Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp

    r144820 r147029  
    221221}
    222222
    223 void IDBCursorBackendImpl::prefetchReset(int usedPrefetches, int unusedPrefetches)
     223void IDBCursorBackendImpl::prefetchReset(int usedPrefetches, int)
    224224{
    225225    IDB_TRACE("IDBCursorBackendImpl::prefetchReset");

  • trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp

    r146540 r147029  
    231231    }
    232232
    233     IndexedDB::TransactionMode mode = IDBTransaction::stringToMode(modeString, context, ec);
     233    IndexedDB::TransactionMode mode = IDBTransaction::stringToMode(modeString, ec);
    234234    if (ec)
    235235        return 0;

  • trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp

    r146225 r147029  
    916916}
    917917
    918 void IDBDatabaseBackendImpl::setIndexesReady(int64_t transactionId, int64_t objectStoreId, const Vector<int64_t>& indexIds)
     918void IDBDatabaseBackendImpl::setIndexesReady(int64_t transactionId, int64_t, const Vector<int64_t>& indexIds)
    919919{
    920920    IDB_TRACE("IDBObjectStoreBackendImpl::setIndexesReady");

  • trunk/Source/WebCore/Modules/indexeddb/IDBIndex.cpp

    r144820 r147029  
    6868        return 0;
    6969    }
    70     IndexedDB::CursorDirection direction = IDBCursor::stringToDirection(directionString, context, ec);
     70    IndexedDB::CursorDirection direction = IDBCursor::stringToDirection(directionString, ec);
    7171    if (ec)
    7272        return 0;
    … …  
    123123        return 0;
    124124    }
    125     IndexedDB::CursorDirection direction = IDBCursor::stringToDirection(directionString, context, ec);
     125    IndexedDB::CursorDirection direction = IDBCursor::stringToDirection(directionString, ec);
    126126    if (ec)
    127127        return 0;

  • trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp

    r146132 r147029  
    727727
    728728template<typename KeyType>
    729 int compare(const LevelDBSlice& a, const LevelDBSlice& b, bool ignoreDuplicates, bool& ok)
     729int compare(const LevelDBSlice& a, const LevelDBSlice& b, bool, bool& ok)
    730730{
    731731    KeyType keyA;
    … …  
    750750
    751751template<>
    752 int compare<ExistsEntryKey>(const LevelDBSlice& a, const LevelDBSlice& b, bool ignoreDuplicates, bool& ok)
     752int compare<ExistsEntryKey>(const LevelDBSlice& a, const LevelDBSlice& b, bool, bool& ok)
    753753{
    754754    KeyPrefix prefixA;
    … …  
    773773
    774774template<>
    775 int compare<ObjectStoreDataKey>(const LevelDBSlice& a, const LevelDBSlice& b, bool ignoreDuplicates, bool& ok)
     775int compare<ObjectStoreDataKey>(const LevelDBSlice& a, const LevelDBSlice& b, bool, bool& ok)
    776776{
    777777    KeyPrefix prefixA;

  • trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp

    r144820 r147029  
    321321    }
    322322
    323     virtual void handleEvent(ScriptExecutionContext* context, Event* event)
     323    virtual void handleEvent(ScriptExecutionContext*, Event* event)
    324324    {
    325325        ASSERT(event->type() == eventNames().successEvent);
    … …  
    505505        return 0;
    506506    }
    507     IndexedDB::CursorDirection direction = IDBCursor::stringToDirection(directionString, context, ec);
     507    IndexedDB::CursorDirection direction = IDBCursor::stringToDirection(directionString, ec);
    508508    if (ec)
    509509        return 0;

  • trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp

    r146629 r147029  
    337337}
    338338
    339 IndexedDB::TransactionMode IDBTransaction::stringToMode(const String& modeString, ScriptExecutionContext* context, ExceptionCode& ec)
     339IndexedDB::TransactionMode IDBTransaction::stringToMode(const String& modeString, ExceptionCode& ec)
    340340{
    341341    if (modeString.isNull()

  • trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h

    r144820 r147029  
    6363    static const AtomicString& modeReadWriteLegacy();
    6464
    65     static IndexedDB::TransactionMode stringToMode(const String&, ScriptExecutionContext*, ExceptionCode&);
     65    static IndexedDB::TransactionMode stringToMode(const String&, ExceptionCode&);
    6666    static const AtomicString& modeToString(IndexedDB::TransactionMode);
    6767

  • trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp

    r146218 r147029  
    203203};
    204204
    205 void ExecutableWithDatabase::start(IDBFactory* idbFactory, SecurityOrigin* securityOrigin, const String& databaseName)
     205void ExecutableWithDatabase::start(IDBFactory* idbFactory, SecurityOrigin*, const String& databaseName)
    206206{
    207207    RefPtr<OpenDatabaseCallback> callback = OpenDatabaseCallback::create(this);
Note: See TracChangeset for help on using the changeset viewer.