Changeset 147035 in webkit


Ignore:
Timestamp:
Mar 27, 2013 5:29:39 PM (11 years ago)
Author:
Claudio Saavedra
Message:

Rename Editing tests whose expectations are Mac specific
​https://bugs.webkit.org/show_bug.cgi?id=113414

Reviewed by Ryosuke Niwa.

These tests have expectations that assume that word selection
works always as in Mac and therefore will break when ran with
editingBehavior set, for instance, to Windows (see bug
110487). Rename them to have the suffix -mac and explicitly set
editingBehavior to Mac.

When the fix for 110487 lands, counterparts to these tests with
suffix -win, editingBehavior set to win, and updated expectations
will be added.

  • editing/deleting/smart-editing-disabled-mac-expected.txt:

Renamed from
LayoutTests/editing/deleting/smart-editing-disabled-expected.txt.

  • editing/deleting/smart-editing-disabled-mac.html: Renamed from

LayoutTests/editing/deleting/smart-editing-disabled.html.

  • editing/execCommand/remove-format-multiple-elements-mac-expected.txt:

Renamed from
LayoutTests/editing/execCommand/remove-format-multiple-elements-expected.txt.

  • editing/execCommand/remove-format-multiple-elements-mac.html:

Renamed from
LayoutTests/editing/execCommand/remove-format-multiple-elements.html.

  • editing/execCommand/script-tests/remove-format-multiple-elements-mac.js:

Renamed from
LayoutTests/editing/execCommand/script-tests/remove-format-multiple-elements.js.

  • editing/execCommand/script-tests/toggle-link-mac.js: Renamed

from LayoutTests/editing/execCommand/script-tests/toggle-link.js.

  • editing/execCommand/toggle-link-mac-expected.txt: Renamed from

LayoutTests/editing/execCommand/toggle-link-expected.txt.

  • editing/execCommand/toggle-link-mac.html: Renamed from

LayoutTests/editing/execCommand/toggle-link.html.

  • editing/style/make-text-writing-direction-inline-mac-expected.txt:

Renamed from
LayoutTests/editing/style/make-text-writing-direction-inline-expected.txt.

  • editing/style/make-text-writing-direction-inline-mac.html:

Renamed from
LayoutTests/editing/style/make-text-writing-direction-inline.html.

  • editing/style/push-down-font-styles-mac-expected.txt: Renamed

from LayoutTests/editing/style/push-down-font-styles-expected.txt.

  • editing/style/push-down-font-styles-mac.html: Renamed from

LayoutTests/editing/style/push-down-implicit-styles.html.

  • editing/style/push-down-implicit-styles-around-list-mac-expected.txt:

Renamed from
LayoutTests/editing/style/push-down-implicit-styles-around-list-expected.txt.

  • editing/style/push-down-implicit-styles-around-list-mac.html:

Renamed from
LayoutTests/editing/style/push-down-implicit-styles-around-list.html.

  • editing/style/push-down-implicit-styles-mac-expected.txt:

Renamed from
LayoutTests/editing/style/push-down-implicit-styles-expected.txt.

  • editing/style/push-down-implicit-styles-mac.html: Renamed from

LayoutTests/editing/style/push-down-font-styles.html.

  • editing/style/script-tests/make-text-writing-direction-inline-mac.js:

Renamed from
LayoutTests/editing/style/script-tests/make-text-writing-direction-inline.js.

  • editing/style/script-tests/push-down-font-styles-mac.js: Renamed

from
LayoutTests/editing/style/script-tests/push-down-font-styles.js.

  • editing/style/script-tests/push-down-implicit-styles-around-list-mac.js:

Renamed from
LayoutTests/editing/style/script-tests/push-down-implicit-styles-around-list.js.

  • editing/style/script-tests/push-down-implicit-styles-mac.js:

Renamed from
LayoutTests/editing/style/script-tests/push-down-implicit-styles.js.

Location:
trunk/LayoutTests
Files:
1 edited
20 moved

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r147034 r147035  
     12013-03-27  Claudio Saavedra  <csaavedra@igalia.com>
     2
     3        Rename Editing tests whose expectations are Mac specific
     4        https://bugs.webkit.org/show_bug.cgi?id=113414
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        These tests have expectations that assume that word selection
     9        works always as in Mac and therefore will break when ran with
     10        editingBehavior set, for instance, to Windows (see bug
     11        110487). Rename them to have the suffix -mac and explicitly set
     12        editingBehavior to Mac.
     13
     14        When the fix for 110487 lands, counterparts to these tests with
     15        suffix -win, editingBehavior set to win, and updated expectations
     16        will be added.
     17
     18        * editing/deleting/smart-editing-disabled-mac-expected.txt:
     19        Renamed from
     20        LayoutTests/editing/deleting/smart-editing-disabled-expected.txt.
     21        * editing/deleting/smart-editing-disabled-mac.html: Renamed from
     22        LayoutTests/editing/deleting/smart-editing-disabled.html.
     23        * editing/execCommand/remove-format-multiple-elements-mac-expected.txt:
     24        Renamed from
     25        LayoutTests/editing/execCommand/remove-format-multiple-elements-expected.txt.
     26        * editing/execCommand/remove-format-multiple-elements-mac.html:
     27        Renamed from
     28        LayoutTests/editing/execCommand/remove-format-multiple-elements.html.
     29        * editing/execCommand/script-tests/remove-format-multiple-elements-mac.js:
     30        Renamed from
     31        LayoutTests/editing/execCommand/script-tests/remove-format-multiple-elements.js.
     32        * editing/execCommand/script-tests/toggle-link-mac.js: Renamed
     33        from LayoutTests/editing/execCommand/script-tests/toggle-link.js.
     34        * editing/execCommand/toggle-link-mac-expected.txt: Renamed from
     35        LayoutTests/editing/execCommand/toggle-link-expected.txt.
     36        * editing/execCommand/toggle-link-mac.html: Renamed from
     37        LayoutTests/editing/execCommand/toggle-link.html.
     38        * editing/style/make-text-writing-direction-inline-mac-expected.txt:
     39        Renamed from
     40        LayoutTests/editing/style/make-text-writing-direction-inline-expected.txt.
     41        * editing/style/make-text-writing-direction-inline-mac.html:
     42        Renamed from
     43        LayoutTests/editing/style/make-text-writing-direction-inline.html.
     44        * editing/style/push-down-font-styles-mac-expected.txt: Renamed
     45        from LayoutTests/editing/style/push-down-font-styles-expected.txt.
     46        * editing/style/push-down-font-styles-mac.html: Renamed from
     47        LayoutTests/editing/style/push-down-implicit-styles.html.
     48        * editing/style/push-down-implicit-styles-around-list-mac-expected.txt:
     49        Renamed from
     50        LayoutTests/editing/style/push-down-implicit-styles-around-list-expected.txt.
     51        * editing/style/push-down-implicit-styles-around-list-mac.html:
     52        Renamed from
     53        LayoutTests/editing/style/push-down-implicit-styles-around-list.html.
     54        * editing/style/push-down-implicit-styles-mac-expected.txt:
     55        Renamed from
     56        LayoutTests/editing/style/push-down-implicit-styles-expected.txt.
     57        * editing/style/push-down-implicit-styles-mac.html: Renamed from
     58        LayoutTests/editing/style/push-down-font-styles.html.
     59        * editing/style/script-tests/make-text-writing-direction-inline-mac.js:
     60        Renamed from
     61        LayoutTests/editing/style/script-tests/make-text-writing-direction-inline.js.
     62        * editing/style/script-tests/push-down-font-styles-mac.js: Renamed
     63        from
     64        LayoutTests/editing/style/script-tests/push-down-font-styles.js.
     65        * editing/style/script-tests/push-down-implicit-styles-around-list-mac.js:
     66        Renamed from
     67        LayoutTests/editing/style/script-tests/push-down-implicit-styles-around-list.js.
     68        * editing/style/script-tests/push-down-implicit-styles-mac.js:
     69        Renamed from
     70        LayoutTests/editing/style/script-tests/push-down-implicit-styles.js.
     71
    1722013-03-27  Yongjun Zhang  <yongjun_zhang@apple.com>
    273

  • trunk/LayoutTests/editing/deleting/smart-editing-disabled-mac.html

    r147034 r147035  
    88    internals.settings.setSelectTrailingWhitespaceEnabled(true);
    99}
     10if (window.internals)
     11    internals.settings.setEditingBehavior('mac');
    1012
    1113function editingTest() {

  • trunk/LayoutTests/editing/execCommand/remove-format-multiple-elements-mac.html

    r147034 r147035  
    77<p id="description"></p>
    88<div id="console"></div>
    9 <script src="script-tests/remove-format-multiple-elements.js"></script>
     9<script src="script-tests/remove-format-multiple-elements-mac.js"></script>
    1010<script src="../../fast/js/resources/js-test-post.js"></script>
    1111</body>

  • trunk/LayoutTests/editing/execCommand/script-tests/remove-format-multiple-elements-mac.js

    r147034 r147035  
    44testContainer.contentEditable = true;
    55document.body.appendChild(testContainer);
     6if (window.internals)
     7    internals.settings.setEditingBehavior("mac");
    68
    79function testRemoveFormat(initialContents, selector, expected)

  • trunk/LayoutTests/editing/execCommand/script-tests/toggle-link-mac.js

    r147034 r147035  
    44testContainer.contentEditable = true;
    55document.body.appendChild(testContainer);
     6if (window.internals)
     7    internals.settings.setEditingBehavior('mac');
    68
    79function testSingleToggle(toggleCommand, initialContents, selector, expectedContents)

  • trunk/LayoutTests/editing/execCommand/toggle-link-mac.html

    r147034 r147035  
    77<p id="description"></p>
    88<div id="console"></div>
    9 <script src="script-tests/toggle-link.js"></script>
     9<script src="script-tests/toggle-link-mac.js"></script>
    1010<script src="../../fast/js/resources/js-test-post.js"></script>
    1111</body>

  • trunk/LayoutTests/editing/style/make-text-writing-direction-inline-mac.html

    r147034 r147035  
    88<p id="description"></p>
    99<div id="console"></div>
    10 <script src="script-tests/make-text-writing-direction-inline.js"></script>
     10<script src="script-tests/make-text-writing-direction-inline-mac.js"></script>
    1111<script src="../../fast/js/resources/js-test-post.js"></script>
    1212</body>

  • trunk/LayoutTests/editing/style/push-down-font-styles-mac.html

    r147034 r147035  
    77<p id="description"></p>
    88<div id="console"></div>
    9 <script src="script-tests/push-down-implicit-styles.js"></script>
     9<script src="script-tests/push-down-font-styles-mac.js"></script>
    1010<script src="../../fast/js/resources/js-test-post.js"></script>
    1111</body>

  • trunk/LayoutTests/editing/style/push-down-implicit-styles-around-list-mac.html

    r147034 r147035  
    77<p id="description"></p>
    88<div id="console"></div>
    9 <script src="script-tests/push-down-implicit-styles-around-list.js"></script>
     9<script src="script-tests/push-down-implicit-styles-around-list-mac.js"></script>
    1010<script src="../../fast/js/resources/js-test-post.js"></script>
    1111</body>

  • trunk/LayoutTests/editing/style/push-down-implicit-styles-mac.html

    r147034 r147035  
    77<p id="description"></p>
    88<div id="console"></div>
    9 <script src="script-tests/push-down-font-styles.js"></script>
     9<script src="script-tests/push-down-implicit-styles-mac.js"></script>
    1010<script src="../../fast/js/resources/js-test-post.js"></script>
    1111</body>

  • trunk/LayoutTests/editing/style/script-tests/make-text-writing-direction-inline-mac.js

    r147034 r147035  
    11description('Tests to ensure MakeTextWritingDirection* modifies the direction of text and embed texts properly.');
    22
     3if (window.internals)
     4    internals.settings.setEditingBehavior('mac');
    35if (!window.testRunner)
    46    testFailed('This test requires testRunner');

  • trunk/LayoutTests/editing/style/script-tests/push-down-font-styles-mac.js

    r147034 r147035  
    11description('Test to make sure we push down inline styles properly.');
    22
     3if (window.internals)
     4    internals.settings.setEditingBehavior('mac');
    35var testContainer = document.createElement("div");
    46testContainer.contentEditable = true;

  • trunk/LayoutTests/editing/style/script-tests/push-down-implicit-styles-around-list-mac.js

    r147034 r147035  
    11description('Test to make sure we push down inline styles properly.');
    22
     3if (window.internals)
     4    internals.settings.setEditingBehavior('mac');
    35var testContainer = document.createElement("div");
    46testContainer.contentEditable = true;

  • trunk/LayoutTests/editing/style/script-tests/push-down-implicit-styles-mac.js

    r147034 r147035  
    11description('Test to make sure we push down inline styles properly.');
    22
     3if (window.internals)
     4    internals.settings.setEditingBehavior('mac');
    35var testContainer = document.createElement("div");
    46testContainer.contentEditable = true;
Note: See TracChangeset for help on using the changeset viewer.