Changeset 147070 in webkit

Timestamp:

Mar 27, 2013 11:39:05 PM (11 years ago)

Author:

keishi@webkit.org

Message:

Dragging to edge should always snap to min/max.
​https://bugs.webkit.org/show_bug.cgi?id=113477

Reviewed by Kent Tamura.

Source/WebCore:

Dragging to the edge of a slider should always snap to the min/max.

Test: fast/forms/range/range-slow-drag-to-edge.html

• html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint):

LayoutTests:

• fast/forms/range/range-slow-drag-to-edge-expected.txt: Added.
• fast/forms/range/range-slow-drag-to-edge.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/range/range-slow-drag-to-edge-expected.txt (added)
• LayoutTests/fast/forms/range/range-slow-drag-to-edge.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/shadow/SliderThumbElement.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-03-27  Keishi Hattori  <keishi@webkit.org>
+
+        Dragging to edge should always snap to min/max.
+        https://bugs.webkit.org/show_bug.cgi?id=113477
+
+        Reviewed by Kent Tamura.
+
+        * fast/forms/range/range-slow-drag-to-edge-expected.txt: Added.
+        * fast/forms/range/range-slow-drag-to-edge.html: Added.
+
 2013-03-27  Shinya Kawanaka  <shinyak@chromium.org> 
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-27  Keishi Hattori  <keishi@webkit.org>
+
+        Dragging to edge should always snap to min/max.
+        https://bugs.webkit.org/show_bug.cgi?id=113477
+
+        Reviewed by Kent Tamura.
+
+        Dragging to the edge of a slider should always snap to the min/max.
+
+        Test: fast/forms/range/range-slow-drag-to-edge.html
+
+        * html/shadow/SliderThumbElement.cpp:
+        (WebCore::SliderThumbElement::setPositionFromPoint):
+
 2013-03-27  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp

@@ -287 +287 @@
     }
     position = max<LayoutUnit>(0, min(position, trackSize));
-    if (position == currentPosition)
-        return;
-
     const Decimal ratio = Decimal::fromDouble(static_cast<double>(position) / trackSize);
     const Decimal fraction = isVertical || !isLeftToRightDirection ? Decimal(1) - ratio : ratio;
@@ -309 +306 @@
 #endif
 
+    String valueString = serializeForNumberType(value);
+    if (valueString == input->value())
+        return;
+
     // FIXME: This is no longer being set from renderer. Consider updating the method name.
-    input->setValueFromRenderer(serializeForNumberType(value));
+    input->setValueFromRenderer(valueString);
     renderer()->setNeedsLayout(true);
     input->dispatchFormControlChangeEvent();