Changeset 147127 in webkit

Timestamp:

Mar 28, 2013 10:03:11 AM (11 years ago)

Author:

alokp@chromium.org

Message:

RenderBox::backgroundIsKnownToBeOpaqueInRect may be wrong for theme-painted elements
​https://bugs.webkit.org/show_bug.cgi?id=113419

Reviewed by Simon Fraser.

Source/WebCore:

Do not consider control elements as opaque. They are typically theme painted, and we cannot assume opaqueness on the behalf of theme. It can be improved by asking the theme if it paints opaque.

Test: compositing/contents-opaque/control-layer.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

• compositing/contents-opaque/control-layer-expected.txt: Added.
• compositing/contents-opaque/control-layer.html: Added.
• platform/chromium/compositing/contents-opaque/control-layer-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/contents-opaque/control-layer-expected.txt (added)
• LayoutTests/compositing/contents-opaque/control-layer.html (added)
• LayoutTests/platform/chromium/compositing/contents-opaque/control-layer-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBox.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-03-28  Alok Priyadarshi  <alokp@chromium.org>
+
+        RenderBox::backgroundIsKnownToBeOpaqueInRect may be wrong for theme-painted elements
+        https://bugs.webkit.org/show_bug.cgi?id=113419
+
+        Reviewed by Simon Fraser.
+
+        * compositing/contents-opaque/control-layer-expected.txt: Added.
+        * compositing/contents-opaque/control-layer.html: Added.
+        * platform/chromium/compositing/contents-opaque/control-layer-expected.txt: Added.
+
 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-28  Alok Priyadarshi  <alokp@chromium.org>
+
+        RenderBox::backgroundIsKnownToBeOpaqueInRect may be wrong for theme-painted elements
+        https://bugs.webkit.org/show_bug.cgi?id=113419
+
+        Reviewed by Simon Fraser.
+
+        Do not consider control elements as opaque. They are typically theme painted, and we cannot assume opaqueness on the behalf of theme. It can be improved by asking the theme if it paints opaque.
+
+        Test: compositing/contents-opaque/control-layer.html
+
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):
+
 2013-03-28  ChangSeok Oh  <changseok.oh@collabora.com>
 

trunk/Source/WebCore/rendering/RenderBox.cpp

@@ -1178 +1178 @@
         return false;
 
+    // If the element has appearance, it might be painted by theme.
+    // We cannot be sure if theme paints the background opaque.
+    // In this case it is safe to not assume opaqueness.
+    // FIXME: May be ask theme if it paints opaque.
+    if (style()->hasAppearance())
+        return false;
     // FIXME: Check the opaqueness of background images.