Changeset 147199 in webkit
- Timestamp:
- Mar 29, 2013 12:36:58 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r147195 r147199 1 2013-03-29 Zalan Bujtas <zalan@apple.com> 2 3 REGRESSION(r143102): Ignore table cell's height attribute when checking if containing block has auto height. 4 https://bugs.webkit.org/show_bug.cgi?id=113526 5 6 Reviewed by Antti Koivisto. 7 8 * fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height-expected.txt: Added. 9 * fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html: Added. 10 1 11 2013-03-28 Sheriff Bot <webkit.review.bot@gmail.com> 2 12 -
trunk/Source/WebCore/ChangeLog
r147198 r147199 1 2013-03-29 Zalan Bujtas <zalan@apple.com> 2 3 REGRESSION(r143102): Ignore table cell's height attribute when checking if containing block has auto height. 4 https://bugs.webkit.org/show_bug.cgi?id=113526 5 6 It matches shipping Safari and Firefox behaviour. 7 8 Reviewed by Antti Koivisto. 9 10 Test: fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html 11 12 * rendering/RenderBoxModelObject.cpp: 13 (WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight): 14 1 15 2013-03-28 Eugene Klyuchnikov <eustas@chromium.org> 2 16 -
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
r147021 r147199 387 387 cb = cb->containingBlock(); 388 388 389 // Matching RenderBox::percentageLogicalHeightIsResolvableFromBlock() by 390 // ignoring table cell's attribute value, where it says that table cells violate 391 // what the CSS spec says to do with heights. Basically we 392 // don't care if the cell specified a height or not. 393 if (cb->isTableCell()) 394 return false; 395 389 396 if (!cb->style()->logicalHeight().isAuto() || (!cb->style()->logicalTop().isAuto() && !cb->style()->logicalBottom().isAuto())) 390 397 return false;
Note: See TracChangeset
for help on using the changeset viewer.