Changeset 147206 in webkit

Timestamp:

Mar 29, 2013, 4:28:54 AM (12 years ago)

Author:

Philippe Normand

Message:

[GStreamer] playback gets bumpy sometimes when on-disk buffering is slow
​https://bugs.webkit.org/show_bug.cgi?id=113512

Reviewed by Martin Robinson.

When the HTTP source element is slow downloading data for on-disk
buffering the playback position might reach an unbuffered region
and have bad consequences, pausing the pipeline beforehand
prevents this case to happen.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::processBufferingStats):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-28  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer] playback gets bumpy sometimes when on-disk buffering is slow
+        https://bugs.webkit.org/show_bug.cgi?id=113512
+
+        Reviewed by Martin Robinson.
+
+        When the HTTP source element is slow downloading data for on-disk
+        buffering the playback position might reach an unbuffered region
+        and have bad consequences, pausing the pipeline beforehand
+        prevents this case to happen.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::processBufferingStats):
+
 2013-03-29  Keishi Hattori  <keishi@webkit.org>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -802 +802 @@
 
         m_fillTimer.startRepeating(0.2);
+    }
+
+    if (!m_paused && m_bufferingPercentage < 100) {
+        LOG_MEDIA_MESSAGE("[Buffering] Download in progress, pausing pipeline.");
+        gst_element_set_state(m_playBin.get(), GST_STATE_PAUSED);
     }
 }