Changeset 147323 in webkit
- Timestamp:
- Apr 1, 2013 7:03:47 AM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r147322 r147323 1 2013-04-01 Pavel Feldman <pfeldman@chromium.org> 2 3 Web Inspector: Go to line dialog has 0 height, viewport dialogs have empty gaps. 4 https://bugs.webkit.org/show_bug.cgi?id=113702 5 6 Reviewed by Yury Semikhatsky. 7 8 * inspector/front-end/DOMExtension.js: 9 (Element.prototype.measurePreferredSize): 10 * inspector/front-end/Popover.js: 11 (WebInspector.Popover.prototype._innerShow): 12 * inspector/front-end/ViewportControl.js: 13 (WebInspector.ViewportControl.prototype.refresh): 14 * inspector/front-end/dialog.css: 15 (.dialog-contents): 16 1 17 2013-04-01 Andrey Lushnikov <lushnikov@chromium.org> 2 18 -
trunk/Source/WebCore/inspector/front-end/DOMExtension.js
r142138 r147323 246 246 247 247 /** 248 * @param {Element} containerElement 248 249 * @return {Size} 249 250 */ 250 Element.prototype.measurePreferredSize = function( )251 { 252 document.body.appendChild(this);251 Element.prototype.measurePreferredSize = function(containerElement) 252 { 253 containerElement.appendChild(this); 253 254 this.positionAt(0, 0); 254 255 var result = new Size(this.offsetWidth, this.offsetHeight); 255 256 this.positionAt(undefined, undefined); 256 document.body.removeChild(this);257 this.removeSelf(); 257 258 return result; 258 259 } -
trunk/Source/WebCore/inspector/front-end/Popover.js
r147209 r147323 95 95 96 96 // Temporarily attach in order to measure preferred dimensions. 97 var preferredSize = view ? view.measurePreferredSize() : this.contentElement.measurePreferredSize( );97 var preferredSize = view ? view.measurePreferredSize() : this.contentElement.measurePreferredSize(this._contentDiv); 98 98 preferredWidth = preferredWidth || preferredSize.width; 99 99 preferredHeight = preferredHeight || preferredSize.height; -
trunk/Source/WebCore/inspector/front-end/ViewportControl.js
r145076 r147323 88 88 if (!this._rowHeight) { 89 89 var firstElement = this._provider.itemElement(0); 90 this._rowHeight = firstElement.measurePreferredSize( ).height;90 this._rowHeight = firstElement.measurePreferredSize(this._contentElement).height; 91 91 } 92 92 … … 96 96 this._firstVisibleIndex = Math.floor(visibleFrom / this._rowHeight); 97 97 this._lastVisibleIndex = Math.min(Math.ceil(visibleTo / this._rowHeight), itemCount) - 1; 98 98 99 this._topGapElement.style.height = (this._rowHeight * this._firstVisibleIndex) + "px"; 99 100 this._bottomGapElement.style.height = (this._rowHeight * (itemCount - this._lastVisibleIndex - 1)) + "px"; -
trunk/Source/WebCore/inspector/front-end/dialog.css
r145943 r147323 18 18 .dialog-contents { 19 19 width: 100%; 20 height: 100%;21 22 20 font-size: 11px; 23 21 font-family: 'Lucida Grande', sans-serif;
Note: See TracChangeset
for help on using the changeset viewer.