Changeset 147323 in webkit


Ignore:
Timestamp:
Apr 1, 2013 7:03:47 AM (11 years ago)
Author:
pfeldman@chromium.org
Message:

Web Inspector: Go to line dialog has 0 height, viewport dialogs have empty gaps.
https://bugs.webkit.org/show_bug.cgi?id=113702

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DOMExtension.js:

(Element.prototype.measurePreferredSize):

  • inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._innerShow):

  • inspector/front-end/ViewportControl.js:

(WebInspector.ViewportControl.prototype.refresh):

  • inspector/front-end/dialog.css:

(.dialog-contents):

Location:
trunk/Source/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r147322 r147323  
     12013-04-01  Pavel Feldman  <pfeldman@chromium.org>
     2
     3        Web Inspector: Go to line dialog has 0 height, viewport dialogs have empty gaps.
     4        https://bugs.webkit.org/show_bug.cgi?id=113702
     5
     6        Reviewed by Yury Semikhatsky.
     7
     8        * inspector/front-end/DOMExtension.js:
     9        (Element.prototype.measurePreferredSize):
     10        * inspector/front-end/Popover.js:
     11        (WebInspector.Popover.prototype._innerShow):
     12        * inspector/front-end/ViewportControl.js:
     13        (WebInspector.ViewportControl.prototype.refresh):
     14        * inspector/front-end/dialog.css:
     15        (.dialog-contents):
     16
    1172013-04-01  Andrey Lushnikov  <lushnikov@chromium.org>
    218
  • trunk/Source/WebCore/inspector/front-end/DOMExtension.js

    r142138 r147323  
    246246
    247247/**
     248 * @param {Element} containerElement
    248249 * @return {Size}
    249250 */
    250 Element.prototype.measurePreferredSize = function()
    251 {
    252     document.body.appendChild(this);
     251Element.prototype.measurePreferredSize = function(containerElement)
     252{
     253    containerElement.appendChild(this);
    253254    this.positionAt(0, 0);
    254255    var result = new Size(this.offsetWidth, this.offsetHeight);
    255256    this.positionAt(undefined, undefined);
    256     document.body.removeChild(this);
     257    this.removeSelf();
    257258    return result;
    258259}
  • trunk/Source/WebCore/inspector/front-end/Popover.js

    r147209 r147323  
    9595
    9696        // Temporarily attach in order to measure preferred dimensions.
    97         var preferredSize = view ? view.measurePreferredSize() : this.contentElement.measurePreferredSize();
     97        var preferredSize = view ? view.measurePreferredSize() : this.contentElement.measurePreferredSize(this._contentDiv);
    9898        preferredWidth = preferredWidth || preferredSize.width;
    9999        preferredHeight = preferredHeight || preferredSize.height;
  • trunk/Source/WebCore/inspector/front-end/ViewportControl.js

    r145076 r147323  
    8888        if (!this._rowHeight) {
    8989            var firstElement = this._provider.itemElement(0);
    90             this._rowHeight = firstElement.measurePreferredSize().height;
     90            this._rowHeight = firstElement.measurePreferredSize(this._contentElement).height;
    9191        }
    9292
     
    9696        this._firstVisibleIndex = Math.floor(visibleFrom / this._rowHeight);
    9797        this._lastVisibleIndex = Math.min(Math.ceil(visibleTo / this._rowHeight), itemCount) - 1;
     98
    9899        this._topGapElement.style.height = (this._rowHeight * this._firstVisibleIndex) + "px";
    99100        this._bottomGapElement.style.height = (this._rowHeight * (itemCount - this._lastVisibleIndex - 1)) + "px";
  • trunk/Source/WebCore/inspector/front-end/dialog.css

    r145943 r147323  
    1818.dialog-contents {
    1919    width: 100%;
    20     height: 100%;
    21 
    2220    font-size: 11px;
    2321    font-family: 'Lucida Grande', sans-serif;
Note: See TracChangeset for help on using the changeset viewer.