Changeset 147353 in webkit

Timestamp:

Apr 1, 2013 1:01:41 PM (11 years ago)

Author:

benjamin@webkit.org

Message:

Remove a couple of malloc from ExceptionBase construction
​https://bugs.webkit.org/show_bug.cgi?id=113681

Reviewed by Darin Adler.

• dom/ExceptionBase.cpp:

(WebCore::ExceptionBase::ExceptionBase):
When the condition is true, we were creating a new String for
description.name. The constructor had already allocated a string for
that: m_name. Use that string instead of creating a new one.

When the condition is false, we were creating a String for typeName
just to use the string operators. This is a waste of time, we can use
makeString() to invoke the string concatenation functions directly.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/ExceptionBase.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-01  Benjamin Poulain  <benjamin@webkit.org>
+
+        Remove a couple of malloc from ExceptionBase construction
+        https://bugs.webkit.org/show_bug.cgi?id=113681
+
+        Reviewed by Darin Adler.
+
+        * dom/ExceptionBase.cpp:
+        (WebCore::ExceptionBase::ExceptionBase):
+        When the condition is true, we were creating a new String for
+        description.name. The constructor had already allocated a string for
+        that: m_name. Use that string instead of creating a new one.
+
+        When the condition is false, we were creating a String for typeName
+        just to use the string operators. This is a waste of time, we can use
+        makeString() to invoke the string concatenation functions directly.
+
 2013-04-01  Emil A Eklund  <eae@chromium.org>
 

trunk/Source/WebCore/dom/ExceptionBase.cpp

@@ -41 +41 @@
 {
     if (description.name)
-        m_message = String(description.name) + ": " + description.typeName + " Exception " + String::number(description.code);
+        m_message = m_name + ": " + description.typeName + " Exception " + String::number(description.code);
     else
-        m_message = String(description.typeName) + " Exception " + String::number(description.code);
+        m_message = makeString(description.typeName, " Exception ", String::number(description.code));
 }