Changeset 147439 in webkit


Ignore:
Timestamp:
Apr 2, 2013 8:58:41 AM (11 years ago)
Author:
Chris Fleizach
Message:

AX: Need to get line thickness from fraction on web
​https://bugs.webkit.org/show_bug.cgi?id=113720

Reviewed by David Kilzer.

Expose the line thickness property for fractions, which is needed to
help determine the type of equation.

Test: platform/mac/accessibility/mathml-line-fraction.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::mathLineThickness):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::mathLineThickness):
(WebCore):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityMathLineThickness]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Location:
trunk
Files:
2 added
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r147436 r147439  
     12013-04-02  Chris Fleizach  <cfleizach@apple.com>
     2
     3        AX: Need to get line thickness from fraction on web
     4        https://bugs.webkit.org/show_bug.cgi?id=113720
     5
     6        Reviewed by David Kilzer.
     7
     8        Expose the line thickness property for fractions, which is needed to
     9        help determine the type of equation.
     10
     11        Test: platform/mac/accessibility/mathml-line-fraction.html
     12
     13        * accessibility/AccessibilityObject.h:
     14        (WebCore::AccessibilityObject::mathLineThickness):
     15        * accessibility/AccessibilityRenderObject.cpp:
     16        (WebCore::AccessibilityRenderObject::mathLineThickness):
     17        (WebCore):
     18        * accessibility/AccessibilityRenderObject.h:
     19        (AccessibilityRenderObject):
     20        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
     21        (-[WebAccessibilityObjectWrapper accessibilityMathLineThickness]):
     22        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
     23        (-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
     24        (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
     25
    1262013-04-02  Alexandre Elias  <aelias@chromium.org>
    227

  • trunk/Source/WebCore/accessibility/AccessibilityObject.h

    r147236 r147439  
    809809    virtual String mathFencedOpenString() const { return String(); }
    810810    virtual String mathFencedCloseString() const { return String(); }
     811    virtual int mathLineThickness() const { return 0; }
    811812   
    812813#if HAVE(ACCESSIBILITY)

  • trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

    r145988 r147439  
    36763676}
    36773677
     3678int AccessibilityRenderObject::mathLineThickness() const
     3679{
     3680    return getAttribute(MathMLNames::linethicknessAttr).toInt();
     3681}
     3682
    36783683#endif
    36793684   

  • trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h

    r145988 r147439  
    321321    virtual String mathFencedOpenString() const;
    322322    virtual String mathFencedCloseString() const;
     323    virtual int mathLineThickness() const;
    323324
    324325    bool isIgnoredElementWithinMathTree() const;

  • trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

    r144766 r147439  
    20032003}
    20042004
     2005- (NSInteger)accessibilityMathLineThickness
     2006{
     2007    if (![self _prepareAccessibilityCall])
     2008        return 0;
     2009
     2010    return m_object->mathLineThickness();
     2011}
     2012
    20052013- (NSString *)accessibilityMathType
    20062014{

  • trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

    r147236 r147439  
    363363#define NSAccessibilityMathFencedOpenAttribute @"AXMathFencedOpen"
    364364#define NSAccessibilityMathFencedCloseAttribute @"AXMathFencedClose"
     365#define NSAccessibilityMathLineThicknessAttribute @"AXMathLineThickness"
    365366
    366367@implementation WebAccessibilityObjectWrapper
    … …  
    10121013        [additional addObject:NSAccessibilityMathFractionNumeratorAttribute];
    10131014        [additional addObject:NSAccessibilityMathFractionDenominatorAttribute];
     1015        [additional addObject:NSAccessibilityMathLineThicknessAttribute];
    10141016    } else if (m_object->isMathSubscriptSuperscript()) {
    10151017        [additional addObject:NSAccessibilityMathBaseAttribute];
    … …  
    26542656        if ([attributeName isEqualToString:NSAccessibilityMathFencedCloseAttribute])
    26552657            return m_object->mathFencedCloseString();
     2658        if ([attributeName isEqualToString:NSAccessibilityMathLineThicknessAttribute])
     2659            return [NSNumber numberWithInteger:m_object->mathLineThickness()];
    26562660    }
    26572661   
Note: See TracChangeset for help on using the changeset viewer.