Changeset 147466 in webkit


Ignore:
Timestamp:
Apr 2, 2013 11:16:36 AM (11 years ago)
Author:
yurys@chromium.org
Message:

Web Inspector: memory instrumentation for external strings is broken
https://bugs.webkit.org/show_bug.cgi?id=113788

Source/WebCore:

Reviewed by Pavel Feldman.

Native memory snapshot now provides information about JS external strings.

Test: inspector/profiler/memory-instrumentation-external-string.html

  • inspector/InspectorMemoryAgent.cpp:

LayoutTests:

Test that native memory snapshot contains information about extenral strings.

Reviewed by Pavel Feldman.

  • inspector/profiler/memory-instrumentation-external-string-expected.txt: Added.
  • inspector/profiler/memory-instrumentation-external-string.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
Location:
trunk
Files:
2 added
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r147465 r147466  
     12013-04-02  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        Web Inspector: memory instrumentation for external strings is broken
     4        https://bugs.webkit.org/show_bug.cgi?id=113788
     5
     6        Test that native memory snapshot contains information about extenral strings.
     7
     8        Reviewed by Pavel Feldman.
     9
     10        * inspector/profiler/memory-instrumentation-external-string-expected.txt: Added.
     11        * inspector/profiler/memory-instrumentation-external-string.html: Added.
     12        * platform/efl/TestExpectations:
     13        * platform/gtk/TestExpectations:
     14        * platform/mac/TestExpectations:
     15        * platform/qt/TestExpectations:
     16        * platform/win/TestExpectations:
     17
    1182013-04-02  Yury Semikhatsky  <yurys@chromium.org>
    219
  • trunk/LayoutTests/platform/efl/TestExpectations

    r147465 r147466  
    14441444webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-array.html [ Skip ]
    14451445
     1446webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-string.html [ Skip ]
     1447
    14461448# ENABLE(INPUT_MULTIPLE_FIELDS_UI) is disabled
    14471449fast/forms/date-multiple-fields
  • trunk/LayoutTests/platform/gtk/TestExpectations

    r147465 r147466  
    947947webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-array.html [ Skip ]
    948948webkit.org/b/99001 inspector/profiler/memory-instrumentation-canvas.html [ Failure ]
     949webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-string.html [ Skip ]
    949950
    950951webkit.org/b/73936 inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases.html [ Failure ]
  • trunk/LayoutTests/platform/mac/TestExpectations

    r147465 r147466  
    289289
    290290webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-array.html [ Skip ]
     291
     292webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-string.html [ Skip ]
    291293
    292294# New inspector/profiler/memory-instrumentation-canvas.html fails on JSC platforms
  • trunk/LayoutTests/platform/qt/TestExpectations

    r147465 r147466  
    274274
    275275webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-array.html [ Skip ]
     276
     277webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-string.html [ Skip ]
    276278
    277279# https://bugs.webkit.org/show_bug.cgi?id=40300
  • trunk/LayoutTests/platform/win/TestExpectations

    r147465 r147466  
    13101310
    13111311webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-array.html [ Skip ]
     1312
     1313webkit.org/b/113787 inspector/profiler/memory-instrumentation-external-string.html [ Skip ]
    13121314
    13131315# New inspector/profiler/memory-instrumentation-canvas.html fails on JSC platforms
  • trunk/Source/WebCore/ChangeLog

    r147465 r147466  
     12013-04-02  Yury Semikhatsky  <yurys@chromium.org>
     2
     3        Web Inspector: memory instrumentation for external strings is broken
     4        https://bugs.webkit.org/show_bug.cgi?id=113788
     5
     6        Reviewed by Pavel Feldman.
     7
     8        Native memory snapshot now provides information about JS external strings.
     9
     10        Test: inspector/profiler/memory-instrumentation-external-string.html
     11
     12        * inspector/InspectorMemoryAgent.cpp:
     13
    1142013-04-02  Yury Semikhatsky  <yurys@chromium.org>
    215
  • trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp

    r147465 r147466  
    161161    virtual void visitJSExternalString(StringImpl* string)
    162162    {
    163         m_memoryClassInfo->addMember(string, "externalString");
     163        m_memoryClassInfo->addMember(string, "externalString", WTF::RetainingPointer);
    164164    }
    165165
Note: See TracChangeset for help on using the changeset viewer.