Changeset 147520 in webkit
- Timestamp:
- Apr 2, 2013 11:17:21 PM (11 years ago)
- Location:
- trunk
- Files:
-
- 21 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r147518 r147520 1 2013-04-02 James Craig <james@cookiecrook.com> 2 3 AXRoleDescripton for DL is "list"; should be "description list" 4 https://bugs.webkit.org/show_bug.cgi?id=111665 5 6 Reviewed by Chris Fleizach. 7 8 Updating expectation strings for DL role description. 9 10 * platform/mac/accessibility/lists-expected.txt: 11 * platform/mac/accessibility/role-subrole-roledescription-expected.txt: 12 * platform/mac/accessibility/role-subrole-roledescription.html: 13 1 14 2013-04-02 Jer Noble <jer.noble@apple.com> 2 15 -
trunk/LayoutTests/platform/mac/accessibility/lists-expected.txt
r140974 r147520 70 70 AXRole: AXList 71 71 AXSubrole: AXDescriptionList 72 AXRoleDescription: list72 AXRoleDescription: description list 73 73 AXChildren: <array of size 5> 74 74 AXHelp: -
trunk/LayoutTests/platform/mac/accessibility/role-subrole-roledescription-expected.txt
r142185 r147520 88 88 AXRole: AXList 89 89 AXSubrole: AXDescriptionList 90 AXRoleDescription: list90 AXRoleDescription: description list 91 91 92 92 PASS: dt -
trunk/LayoutTests/platform/mac/accessibility/role-subrole-roledescription.html
r142185 r147520 28 28 <!-- skipped <details/summary> http://webkit.org/b/108979 --> 29 29 <!-- <dfn> http://webkit.org/b/108980 --><dfn data-role="" data-subrole="" data-roledescription="" class="ex">X</dfn> 30 <dl data-role="AXList" data-subrole="AXDescriptionList" data-roledescription=" list" class="ex">30 <dl data-role="AXList" data-subrole="AXDescriptionList" data-roledescription="description list" class="ex"> 31 31 <dt data-role="AXGroup" data-subrole="AXTerm" data-roledescription="term" class="ex">X</dt> 32 32 <dd data-role="AXGroup" data-subrole="AXDescription" data-roledescription="description" class="ex">X</dd> -
trunk/Source/WebCore/ChangeLog
r147519 r147520 1 2013-04-02 James Craig <james@cookiecrook.com> 2 3 AXRoleDescripton for DL is "list"; should be "description list" 4 https://bugs.webkit.org/show_bug.cgi?id=111665 5 6 Reviewed by Chris Fleizach. 7 8 Defining the role and description strings, and accessors for DL. 9 This previously relied on getting the role and description from the platform API. 10 11 Updated existing test coverage. 12 13 * English.lproj/Localizable.strings: 14 * accessibility/AccessibilityObject.h: 15 * accessibility/AccessibilityRenderObject.cpp: 16 (WebCore::AccessibilityRenderObject::determineAccessibilityRole): 17 * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: 18 (createAccessibilityRoleMap): 19 (-[WebAccessibilityObjectWrapper subrole]): 20 (-[WebAccessibilityObjectWrapper roleDescription]): 21 * platform/LocalizedStrings.cpp: 22 (WebCore::AXDescriptionListText): 23 (WebCore): 24 * platform/LocalizedStrings.h: 25 (WebCore): 26 * platform/blackberry/LocalizedStringsBlackBerry.cpp: 27 (WebCore::AXDescriptionListText): 28 (WebCore): 29 * platform/chromium/LocalizedStringsChromium.cpp: 30 (WebCore::AXDescriptionListText): 31 (WebCore): 32 * platform/efl/LocalizedStringsEfl.cpp: 33 (WebCore::AXDescriptionListText): 34 (WebCore): 35 * platform/gtk/LocalizedStringsGtk.cpp: 36 (WebCore::AXDescriptionListText): 37 (WebCore): 38 * platform/qt/LocalizedStringsQt.cpp: 39 (WebCore::AXDescriptionListText): 40 (WebCore): 41 1 42 2013-04-02 Eugene Klyuchnikov <eustas@chromium.org> 2 43 -
trunk/Source/WebCore/English.lproj/Localizable.strings
r147343 r147520 644 644 "description" = "description"; 645 645 646 /* description list */ 647 "description list" = "description list"; 648 646 649 /* An ARIA accessibility group that acts as an dialog. */ 647 650 "dialog" = "dialog"; -
trunk/Source/WebCore/accessibility/AccessibilityObject.h
r147439 r147520 113 113 ComboBoxRole, 114 114 DefinitionRole, 115 DescriptionListRole, 115 116 DescriptionListTermRole, 116 117 DescriptionListDetailRole, -
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
r147439 r147520 2478 2478 return DescriptionListTermRole; 2479 2479 2480 if (node && node->hasTagName(dlTag)) 2481 return DescriptionListRole; 2482 2480 2483 if (node && (node->hasTagName(rpTag) || node->hasTagName(rtTag))) 2481 2484 return AnnotationRole; -
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
r147439 r147520 1591 1591 { DescriptionListDetailRole, NSAccessibilityGroupRole }, 1592 1592 { DescriptionListTermRole, NSAccessibilityGroupRole }, 1593 { DescriptionListRole, NSAccessibilityListRole }, 1593 1594 { SliderThumbRole, NSAccessibilityValueIndicatorRole }, 1594 1595 { LandmarkApplicationRole, NSAccessibilityGroupRole }, … … 1741 1742 case DefinitionRole: 1742 1743 return @"AXDefinition"; 1744 case DescriptionListRole: 1745 return @"AXDescriptionList"; 1743 1746 case DescriptionListTermRole: 1744 1747 return @"AXTerm"; … … 1877 1880 return AXFileUploadButtonText(); 1878 1881 1882 // Only returning for DL (not UL or OL) because description changed with HTML5 from 'definition list' to 1883 // superset 'description list' and does not return the same values in AX API on some OS versions. 1884 if (m_object->isList()) { 1885 AccessibilityList* listObject = static_cast<AccessibilityList*>(m_object); 1886 if (listObject->isDescriptionList()) 1887 return AXDescriptionListText(); 1888 } 1889 1879 1890 // AppKit also returns AXTab for the role description for a tab item. 1880 1891 if (m_object->isTabItem()) -
trunk/Source/WebCore/platform/LocalizedStrings.cpp
r147343 r147520 561 561 { 562 562 return WEB_UI_STRING("definition", "role description of ARIA definition role"); 563 } 564 565 String AXDescriptionListText() 566 { 567 return WEB_UI_STRING("description list", "accessibility role description of a description list"); 563 568 } 564 569 -
trunk/Source/WebCore/platform/LocalizedStrings.h
r146380 r147520 154 154 String AXHeadingText(); 155 155 String AXDefinitionText(); 156 String AXDescriptionListText(); 156 157 String AXDescriptionListTermText(); 157 158 String AXDescriptionListDetailText(); -
trunk/Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp
r142507 r147520 395 395 } 396 396 397 String AXDescriptionListText() 398 { 399 notImplemented(); 400 return String(); 401 } 402 397 403 String AXDescriptionListDetailText() 398 404 { -
trunk/Source/WebCore/platform/chromium/LocalizedStringsChromium.cpp
r142507 r147520 150 150 notImplemented(); 151 151 return String("definition"); 152 } 153 154 String AXDescriptionListText() 155 { 156 notImplemented(); 157 return String("description list"); 152 158 } 153 159 -
trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp
r145025 r147520 364 364 } 365 365 366 String AXDescriptionListText() 367 { 368 return String::fromUTF8("description list"); 369 } 370 366 371 String AXDescriptionListTermText() 367 372 { -
trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp
r147343 r147520 411 411 { 412 412 return String::fromUTF8(_("definition")); 413 } 414 415 String AXDescriptionListText() 416 { 417 return String::fromUTF8(_("description list")); 413 418 } 414 419 -
trunk/Source/WebCore/platform/qt/LocalizedStringsQt.cpp
r143232 r147520 381 381 382 382 String AXDefinitionText() 383 { 384 notImplemented(); 385 return String(); 386 } 387 388 String AXDescriptionListText() 383 389 { 384 390 notImplemented(); -
trunk/Source/WebKit/chromium/ChangeLog
r147491 r147520 1 2013-04-02 James Craig <james@cookiecrook.com> 2 3 AXRoleDescripton for DL is "list"; should be "description list" 4 https://bugs.webkit.org/show_bug.cgi?id=111665 5 6 Reviewed by Chris Fleizach. 7 8 Defining the role and description strings. 9 10 * public/WebAccessibilityRole.h: 11 * src/AssertMatchingEnums.cpp: 12 1 13 2013-04-02 Raymond Toy <rtoy@google.com> 2 14 -
trunk/Source/WebKit/chromium/public/WebAccessibilityRole.h
r140974 r147520 58 58 WebAccessibilityRoleComboBox, 59 59 WebAccessibilityRoleDefinition, 60 WebAccessibilityRoleDescriptionList, 60 61 WebAccessibilityRoleDescriptionListTerm, 61 62 WebAccessibilityRoleDescriptionListDetail, -
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp
r147192 r147520 227 227 COMPILE_ASSERT_MATCHING_ENUM(WebAccessibilityRoleTableHeaderContainer, TableHeaderContainerRole); 228 228 COMPILE_ASSERT_MATCHING_ENUM(WebAccessibilityRoleDefinition, DefinitionRole); 229 COMPILE_ASSERT_MATCHING_ENUM(WebAccessibilityRoleDescriptionList, DescriptionListRole); 229 230 COMPILE_ASSERT_MATCHING_ENUM(WebAccessibilityRoleDescriptionListTerm, DescriptionListTermRole); 230 231 COMPILE_ASSERT_MATCHING_ENUM(WebAccessibilityRoleDescriptionListDetail, DescriptionListDetailRole); -
trunk/Tools/ChangeLog
r147509 r147520 1 2013-04-02 James Craig <james@cookiecrook.com> 2 3 AXRoleDescripton for DL is "list"; should be "description list" 4 https://bugs.webkit.org/show_bug.cgi?id=111665 5 6 Reviewed by Chris Fleizach. 7 8 Defining the role and description strings. 9 10 * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: 11 1 12 2013-04-02 Roger Fong <roger_fong@apple.com> 2 13 -
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp
r142237 r147520 171 171 case WebAccessibilityRoleDefinition: 172 172 return result.append("Definition"); 173 case WebAccessibilityRoleDescriptionList: 174 return result.append("DescriptionList"); 173 175 case WebAccessibilityRoleDescriptionListTerm: 174 176 return result.append("DescriptionListTerm");
Note: See TracChangeset
for help on using the changeset viewer.