Changeset 147557 in webkit

Timestamp:

Apr 3, 2013 8:18:07 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] WebKitWebNavigationAction: fix mix between dispose and finalize
​https://bugs.webkit.org/show_bug.cgi?id=113794

Patch by Alban Crequy <​alban.crequy@collabora.co.uk> on 2013-04-03
Reviewed by Gustavo Noronha Silva.

WebKitWebNavigationAction's dispose function was named finalize and was calling
the parent class's finalise function, causing a memory corruption. Change it to
be a proper finalize function instead.

• webkit/webkitwebnavigationaction.cpp:

(webkit_web_navigation_action_class_init):

Location:

trunk/Source/WebKit/gtk

Files:

• ChangeLog (modified) (1 diff)
• webkit/webkitwebnavigationaction.cpp (modified) (1 diff)

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2013-04-03  Alban Crequy  <alban.crequy@collabora.co.uk>
+
+        [GTK] WebKitWebNavigationAction: fix mix between dispose and finalize
+        https://bugs.webkit.org/show_bug.cgi?id=113794
+
+        Reviewed by Gustavo Noronha Silva.
+
+        WebKitWebNavigationAction's dispose function was named finalize and was calling
+        the parent class's finalise function, causing a memory corruption. Change it to
+        be a proper finalize function instead.
+
+        * webkit/webkitwebnavigationaction.cpp:
+        (webkit_web_navigation_action_class_init):
+
 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebKit/gtk/webkit/webkitwebnavigationaction.cpp

@@ -135 +135 @@
     objectClass->get_property = webkit_web_navigation_action_get_property;
     objectClass->set_property = webkit_web_navigation_action_set_property;
-    objectClass->dispose = webkit_web_navigation_action_finalize;
+    objectClass->finalize = webkit_web_navigation_action_finalize;
 
     /**