Changeset 147597 in webkit


Ignore:
Timestamp:
Apr 3, 2013 5:05:54 PM (11 years ago)
Author:
hmuller@adobe.com
Message:

[CSS Exclusions] Removed ExclusionShape dead code
https://bugs.webkit.org/show_bug.cgi?id=113904

Reviewed by Dirk Schulze.

No new tests, just removing dead code.

  • rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape):

  • rendering/ExclusionShape.h:

(ExclusionShape):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r147594 r147597  
     12013-04-03  Hans Muller  <hmuller@adobe.com>
     2
     3        [CSS Exclusions] Removed ExclusionShape dead code
     4        https://bugs.webkit.org/show_bug.cgi?id=113904
     5
     6        Reviewed by Dirk Schulze.
     7
     8        No new tests, just removing dead code.
     9
     10        * rendering/ExclusionShape.cpp:
     11        (WebCore::ExclusionShape::createExclusionShape):
     12        * rendering/ExclusionShape.h:
     13        (ExclusionShape):
     14
    1152013-04-03  Otto Derek Cheung  <otcheung@rim.com>
    216
  • trunk/Source/WebCore/rendering/ExclusionShape.cpp

    r146938 r147597  
    117117
    118118        exclusionShape = createExclusionRectangle(logicalBounds, physicalSizeToLogical(cornerRadii, writingMode));
    119         exclusionShape->m_boundingBox = logicalBounds;
    120119        break;
    121120    }
     
    129128
    130129        exclusionShape = createExclusionCircle(logicalCenter, radius);
    131         exclusionShape->m_boundingBox = FloatRect(logicalCenter.x() - radius, logicalCenter.y() - radius, radius * 2, radius * 2);
    132130        break;
    133131    }
     
    143141
    144142        exclusionShape = createExclusionEllipse(logicalCenter, logicalRadii);
    145         exclusionShape->m_boundingBox = FloatRect(logicalCenter - logicalRadii, logicalRadii + logicalRadii);
    146143        break;
    147144    }
     
    152149        size_t valuesSize = values.size();
    153150        ASSERT(!(valuesSize % 2));
    154         FloatRect boundingBox;
    155151        Vector<FloatPoint>* vertices = new Vector<FloatPoint>(valuesSize / 2);
    156152        for (unsigned i = 0; i < valuesSize; i += 2) {
     
    159155                floatValueForLength(values.at(i + 1), boxHeight));
    160156            (*vertices)[i / 2] = physicalPointToLogical(vertex, logicalBoxHeight, writingMode);
    161             if (!i)
    162                 boundingBox.setLocation(vertex);
    163             else
    164                 boundingBox.extend(vertex);
    165157        }
     158
    166159        exclusionShape = createExclusionPolygon(adoptPtr(vertices), polygon->windRule());
    167         exclusionShape->m_boundingBox = boundingBox;
    168160        break;
    169161    }
  • trunk/Source/WebCore/rendering/ExclusionShape.h

    r147384 r147597  
    7777    float m_logicalBoxWidth;
    7878    float m_logicalBoxHeight;
    79     FloatRect m_boundingBox;
    8079    float m_margin;
    8180    float m_padding;
Note: See TracChangeset for help on using the changeset viewer.