Changeset 147638 in webkit

Timestamp:

Apr 4, 2013 9:28:43 AM (11 years ago)

Author:

akling@apple.com

Message:

Render images with low-quality scaling while FrameView is being resized.
<​http://webkit.org/b/113764>
<rdar://problem/13555154>

Reviewed by Antti Koivisto.

Have ImageQualityController ask the renderer's containing FrameView if it's currently in live
resize, and if so, paint all images with low-quality scaling. A high-quality repaint will happen
~0.5 sec after live resizing ends, piggybacking on the same mechanism we use to do JS-animated
resizing with low-quality scaling.

This reduces CPU time spent generating new tiles during live window resize, especially on Retina
systems where a lot of upscaling happens on legacy web content.

• rendering/RenderBoxModelObject.cpp:

(ImageQualityController):

Added an m_liveResizeOptimizationIsActive flag that tracks whether the ImageQualityController
is painting everything in low quality due to live window resize. It gets unset when the HQ
repaint timer fires and everything has been repainted properly.

(WebCore::ImageQualityController::highQualityRepaintTimerFired):

When the HQ repaint timer fires, check if the renderer's containing FrameView is still in
live resize, and if so, abort HQ repaint for now and reschedule the timer.

(WebCore::ImageQualityController::ImageQualityController):
(WebCore::ImageQualityController::objectDestroyed):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBoxModelObject.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-04-04  Andreas Kling  <akling@apple.com>
+
+        Render images with low-quality scaling while FrameView is being resized.
+        <http://webkit.org/b/113764>
+        <rdar://problem/13555154>
+
+        Reviewed by Antti Koivisto.
+
+        Have ImageQualityController ask the renderer's containing FrameView if it's currently in live
+        resize, and if so, paint all images with low-quality scaling. A high-quality repaint will happen
+        ~0.5 sec after live resizing ends, piggybacking on the same mechanism we use to do JS-animated
+        resizing with low-quality scaling.
+
+        This reduces CPU time spent generating new tiles during live window resize, especially on Retina
+        systems where a lot of upscaling happens on legacy web content.
+
+        * rendering/RenderBoxModelObject.cpp:
+        (ImageQualityController):
+
+            Added an m_liveResizeOptimizationIsActive flag that tracks whether the ImageQualityController
+            is painting everything in low quality due to live window resize. It gets unset when the HQ
+            repaint timer fires and everything has been repainted properly.
+
+        (WebCore::ImageQualityController::highQualityRepaintTimerFired):
+
+            When the HQ repaint timer fires, check if the renderer's containing FrameView is still in
+            live resize, and if so, abort HQ repaint for now and reschedule the timer.
+
+        (WebCore::ImageQualityController::ImageQualityController):
+        (WebCore::ImageQualityController::objectDestroyed):
+        (WebCore::ImageQualityController::shouldPaintAtLowQuality):
+
 2013-04-04  Seokju Kwon  <seokju.kwon@gmail.com>
 

trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp

@@ -91 +91 @@
     Timer<ImageQualityController> m_timer;
     bool m_animatedResizeIsActive;
+    bool m_liveResizeOptimizationIsActive;
 };
 
@@ -96 +97 @@
     : m_timer(this, &ImageQualityController::highQualityRepaintTimerFired)
     , m_animatedResizeIsActive(false)
+    , m_liveResizeOptimizationIsActive(false)
 {
 }
@@ -130 +132 @@
 void ImageQualityController::highQualityRepaintTimerFired(Timer<ImageQualityController>*)
 {
-    if (m_animatedResizeIsActive) {
-        m_animatedResizeIsActive = false;
-        for (ObjectLayerSizeMap::iterator it = m_objectLayerSizeMap.begin(); it != m_objectLayerSizeMap.end(); ++it)
-            it->key->repaint();
-    }
+    if (!m_animatedResizeIsActive && !m_liveResizeOptimizationIsActive)
+        return;
+    m_animatedResizeIsActive = false;
+
+    for (ObjectLayerSizeMap::iterator it = m_objectLayerSizeMap.begin(); it != m_objectLayerSizeMap.end(); ++it) {
+        if (Frame* frame = it->key->document()->frame()) {
+            // If this renderer's containing FrameView is in live resize, punt the timer and hold back for now.
+            if (frame->view() && frame->view()->inLiveResize()) {
+                restartTimer();
+                return;
+            }
+        }
+        it->key->repaint();
+    }
+
+    m_liveResizeOptimizationIsActive = false;
 }
 
@@ -166 +179 @@
             isFirstResize = false;
             oldSize = j->value;
+        }
+    }
+
+    // If the containing FrameView is being resized, paint at low quality until resizing is finished.
+    if (Frame* frame = object->document()->frame()) {
+        bool frameViewIsCurrentlyInLiveResize = frame->view() && frame->view()->inLiveResize();
+        if (frameViewIsCurrentlyInLiveResize) {
+            set(object, innerMap, layer, size);
+            restartTimer();
+            m_liveResizeOptimizationIsActive = true;
+            return true;
+        }
+        if (m_liveResizeOptimizationIsActive) {
+            // Live resize has ended, paint in HQ and remove this object from the list.
+            removeLayer(object, innerMap, layer);
+            return false;
         }
     }