Changeset 147664 in webkit

Timestamp:

Apr 4, 2013, 12:58:45 PM (12 years ago)

Author:

timothy_horton@apple.com

Message:

REGRESSION (r147373): Auto-sizing doesn't always respect minimum width changes
​https://bugs.webkit.org/show_bug.cgi?id=113947
<rdar://problem/13579024>

Reviewed by Anders Carlsson.

Reset the FrameView size to the minimum auto-sizing size
before performing auto-sizing. We were already resetting the height,
but not the width, instead using the FrameView's current width.

This means that changing the minimum width without also manually
resizing the FrameView will never see the width change.

Auto-sizing tests are not working on Mac yet.

• page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FrameView.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog ¶

@@ +1 @@
+2013-04-04  Tim Horton  <timothy_horton@apple.com>
+
+        REGRESSION (r147373): Auto-sizing doesn't always respect minimum width changes
+        https://bugs.webkit.org/show_bug.cgi?id=113947
+        <rdar://problem/13579024>
+
+        Reviewed by Anders Carlsson.
+
+        Reset the FrameView size to the minimum auto-sizing size
+        before performing auto-sizing. We were already resetting the height,
+        but not the width, instead using the FrameView's current width.
+
+        This means that changing the minimum width without also manually
+        resizing the FrameView will never see the width change.
+
+        Auto-sizing tests are not working on Mac yet.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::autoSizeIfEnabled):
+
 2013-04-04  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebCore/page/FrameView.cpp ¶

@@ -2779 +2779 @@
         return;
 
-    // Start from the minimum height and allow it to grow.
-    resize(frameRect().width(), m_minAutoSize.height());
+    // Start from the minimum size and allow it to grow.
+    resize(m_minAutoSize.width(), m_minAutoSize.height());
 
     IntSize size = frameRect().size();